New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 862770



Sign in to add a comment
link

Issue 904007: Add .gitattributes files specifying which files to skip for Tricium

Reported by qyears...@chromium.org, Nov 9 Project Member

Issue description

For  bug 862770  (skipping generated/expectation files), the planned solution is to specify which files to skip by .gitattributes files. An initial change to GitFileIsolator is made in https://chromium-review.googlesource.com/c/infra/infra/+/1329751 which explicitly lists some patterns of files to skip; this list of patterns should be replaced by .gitattributes files.
 

Comment 1 by qyears...@chromium.org, Jan 1

Owner: qyears...@chromium.org
Status: Assigned (was: Available)

Comment 2 by qyears...@chromium.org, Jan 2

Status: Started (was: Assigned)

Comment 3 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/42d3fbee5ce2c8de5a80a71b7bd08071fc390fb1

commit 42d3fbee5ce2c8de5a80a71b7bd08071fc390fb1
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jan 10 17:54:57 2019

[tricium isolator] Filter files to skip based on .gitattributes

This change would make the Tricium git file isolator skip files
according to directives in .gitattributes.

After this change, users can tell Tricium to skip a set of files
by adding lines like the following to a .gitattributes file:
  *.generated -tricium

Note: Later, if we want to expand this functionality to allow
skipping of particular analyzers, we could potentially additionally
allow lines like:
  *.generated tricium=-Spacey,Copyright

The way to check which files to skip using .gitattribute files
requires several steps:
 1. Find out which relevant .gitattributes files exist.
    (This can be done with git ls-tree).
 2. Check out just those files.
 3. Call git check-attr and interpret the output.

Bug:  904007 
Change-Id: I292b76b85610800c872bb616167abc05ab918901
Reviewed-on: https://chromium-review.googlesource.com/c/1394212
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19898}
[modify] https://crrev.com/42d3fbee5ce2c8de5a80a71b7bd08071fc390fb1/go/src/infra/tricium/functions/git-file-isolator/isolator_test.go
[modify] https://crrev.com/42d3fbee5ce2c8de5a80a71b7bd08071fc390fb1/go/src/infra/tricium/docs/user-guide.md
[modify] https://crrev.com/42d3fbee5ce2c8de5a80a71b7bd08071fc390fb1/go/src/infra/tricium/functions/git-file-isolator/isolator.go

Comment 4 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/367e40cac1f1ad2186e2f505f339e459a8b41d13

commit 367e40cac1f1ad2186e2f505f339e459a8b41d13
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jan 10 18:36:52 2019

[tricium] Set skip-tricium attributes for luci-go

Bug:  904007 
Change-Id: Ifcb10d29242be326a44378e34c242649c6318810
Reviewed-on: https://chromium-review.googlesource.com/c/1395046
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[add] https://crrev.com/367e40cac1f1ad2186e2f505f339e459a8b41d13/.gitattributes

Comment 5 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f16664a6b742736a94b77dbf0b8edd14748bc328

commit f16664a6b742736a94b77dbf0b8edd14748bc328
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Jan 10 21:45:33 2019

Roll src/third_party/pdfium 084a842135de..96a7d9e4ca4a (9 commits)

https://pdfium.googlesource.com/pdfium.git/+log/084a842135de..96a7d9e4ca4a


git log 084a842135de..96a7d9e4ca4a --date=short --no-merges --format='%ad %ae %s'
2019-01-10 tsepez@chromium.org Move FX_BIDICLASS to fx_unicode.h.
2019-01-10 qyearsley@chromium.org [tricium] Set skip-tricium attributes for pdfium.
2019-01-10 thestig@chromium.org Limit the scope of a using statement in CFX_SystemHandler's header.
2019-01-10 thestig@chromium.org Clean up GlobalTimer.
2019-01-10 thestig@chromium.org Fix default CPDFSDK_FormFillEnvironment::SetTimer() return value.
2019-01-10 thestig@chromium.org Add CFX_SystemHandler::kInvalidTimerID.
2019-01-10 tsepez@chromium.org Make FX_BIDICLASS an enum class.
2019-01-10 thestig@chromium.org Make GlobalTimer's timer ID type consistent.
2019-01-10 thestig@chromium.org Do not add invalid timers to the global map for CPWL_Timer.


Created with:
  gclient setdep -r src/third_party/pdfium@96a7d9e4ca4a

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:904007 
TBR=dsinclair@chromium.org

Change-Id: I63a0f0a097c461fe305940d67878030d565115a5
Reviewed-on: https://chromium-review.googlesource.com/c/1406009
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#621744}
[modify] https://crrev.com/f16664a6b742736a94b77dbf0b8edd14748bc328/DEPS

Comment 6 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/add955b2e07397c3d3596273a1b3c8002cd54c91

commit add955b2e07397c3d3596273a1b3c8002cd54c91
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jan 11 21:55:44 2019

[tricium] Set -tricium git attributes for luci-py

Bug:  904007 
Change-Id: I15b9b03ae6a8baa03990805e6dd5a2b962bb5b3b
Reviewed-on: https://chromium-review.googlesource.com/c/1394759
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[add] https://crrev.com/add955b2e07397c3d3596273a1b3c8002cd54c91/.gitattributes

Comment 7 by bugdroid1@chromium.org, Jan 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/24f18caf48063a1779555d55203363cbd0575320

commit 24f18caf48063a1779555d55203363cbd0575320
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jan 11 22:03:13 2019

[tricium] Set -tricium git attributes for infra

Bug:  904007 
Change-Id: Iafdd7b6344e17b9a998e2d438f4fad1c6fab89cc
Reviewed-on: https://chromium-review.googlesource.com/c/1394815
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19942}
[modify] https://crrev.com/24f18caf48063a1779555d55203363cbd0575320/.gitattributes

Comment 8 by qyears...@chromium.org, Jan 15

Status: Fixed (was: Started)

Comment 9 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b11f2fb4689705f851a4f89fc4a24c09ce2c96f

commit 3b11f2fb4689705f851a4f89fc4a24c09ce2c96f
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jan 17 14:04:30 2019

[tricium] Set -tricium git attributes for chromium

This would disable Tricium* running jobs on files in third_party/,
with the exception of third_party/blink/, which should be analyzed
except for web test expectation files.

* https://chromium.googlesource.com/infra/infra/+/master/go/src/infra/tricium

Bug:  904007 
Change-Id: I5369a20cc42417756430adc46f9efe0114b7f385
Reviewed-on: https://chromium-review.googlesource.com/c/1394935
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623674}
[modify] https://crrev.com/3b11f2fb4689705f851a4f89fc4a24c09ce2c96f/.gitattributes
[add] https://crrev.com/3b11f2fb4689705f851a4f89fc4a24c09ce2c96f/third_party/blink/.gitattributes

Comment 10 by bugdroid1@chromium.org, Jan 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8ec3bcd991dfc2c3006604d0201c65d5b2fb1902

commit 8ec3bcd991dfc2c3006604d0201c65d5b2fb1902
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Sun Jan 20 18:55:11 2019

[tricium isolator] Remove pattern-based skipping

It has now been replaced by skipping based on gitattributes.

Bug:  904007 
Change-Id: I751af2ca4f2526c7c0e6c5015ef9562645cd7eae
Reviewed-on: https://chromium-review.googlesource.com/c/1407468
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20089}
[modify] https://crrev.com/8ec3bcd991dfc2c3006604d0201c65d5b2fb1902/go/src/infra/tricium/functions/git-file-isolator/isolator_test.go
[modify] https://crrev.com/8ec3bcd991dfc2c3006604d0201c65d5b2fb1902/go/src/infra/tricium/functions/git-file-isolator/isolator.go

Sign in to add a comment