New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment
link

Issue 904000: Quota estimate usage - per system details

Reported by jarrydg@chromium.org, Nov 9 Project Member

Issue description

Feature description: Add usage details to the result of storageManager.estimate()

Eng owner: jarrydg@chromium.org
Product owner: jarrydg@chromium.org


There have been frequent requests from users of `navigator.storage.estimate()` to provide a per storage type breakdown estimation.  Currently, a call to this function yields only an estimate of the quota usage for all storage systems combined, making it difficult to reason about what is using up quota.

Ongoing discussion regarding this change: https://github.com/whatwg/storage/issues/63
 

Comment 1 by jarrydg@chromium.org, Nov 12

Description: Show this description

Comment 2 by jarrydg@chromium.org, Nov 21

Description: Show this description

Comment 3 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7fe32949f956437636814291ba942c2e911dc91

commit a7fe32949f956437636814291ba942c2e911dc91
Author: Jarryd <jarrydg@chromium.org>
Date: Wed Nov 28 01:27:12 2018

Quota: Send usage details in return value of estimate().

Change-Id: I85fd510b4245f966e32340b9d433f7d9b96b3810
Bug: 904000
Reviewed-on: https://chromium-review.googlesource.com/c/1303041
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611491}
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/content/browser/devtools/protocol/storage_handler.cc
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/content/browser/quota_dispatcher_host.cc
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/content/browser/quota_dispatcher_host.h
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/storage/browser/quota/quota_callbacks.h
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/storage/browser/quota/quota_manager.cc
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/storage/browser/quota/quota_manager.h
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/storage/browser/quota/quota_manager_unittest.cc
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/storage/browser/quota/usage_tracker.cc
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/storage/browser/quota/usage_tracker.h
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/storage/browser/quota/usage_tracker_unittest.cc
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/storage/browser/test/mock_quota_manager.h
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/public/mojom/quota/quota_dispatcher_host.mojom
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/public/mojom/quota/quota_types.mojom
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/renderer/modules/quota/deprecated_storage_quota.cc
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/renderer/modules/quota/storage_estimate.idl
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/renderer/modules/quota/storage_manager.cc
[add] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/renderer/modules/quota/storage_usage_details.idl
[modify] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/renderer/platform/runtime_enabled_features.json5
[add] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details-indexeddb.https.tentative.any.js
[add] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/web_tests/external/wpt/storage/helpers.js
[add] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/web_tests/virtual/stable/webexposed/storage-estimate-usage-details-expected.txt
[add] https://crrev.com/a7fe32949f956437636814291ba942c2e911dc91/third_party/blink/web_tests/webexposed/storage-estimate-usage-details.html

Comment 4 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/548e7b5e622ad79155ff95ef26738d7a40fe9397

commit 548e7b5e622ad79155ff95ef26738d7a40fe9397
Author: Jarryd <jarrydg@chromium.org>
Date: Thu Dec 13 19:43:20 2018

Add quota usage details tests for all other storage backends.

IndexedDB test was included in parent CL.

Bug: 904000
Test: 
Change-Id: Icc3462f13d0dce0197a8ec54f22d5ad794a51292
Reviewed-on: https://chromium-review.googlesource.com/c/1334659
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616398}
[add] https://crrev.com/548e7b5e622ad79155ff95ef26738d7a40fe9397/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details-application-cache.https.tentative.html
[add] https://crrev.com/548e7b5e622ad79155ff95ef26738d7a40fe9397/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details-caches.https.tentative.any.js
[add] https://crrev.com/548e7b5e622ad79155ff95ef26738d7a40fe9397/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details-service-workers.https.tentative.window.js
[add] https://crrev.com/548e7b5e622ad79155ff95ef26738d7a40fe9397/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details.https.tentative.any.js
[add] https://crrev.com/548e7b5e622ad79155ff95ef26738d7a40fe9397/third_party/blink/web_tests/external/wpt/storage/resources/appcache.manifest
[add] https://crrev.com/548e7b5e622ad79155ff95ef26738d7a40fe9397/third_party/blink/web_tests/external/wpt/storage/resources/iframe_with_appcache_manifest.html

Comment 5 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8ec73bfb3656cc89b7d7e848547312bcdf4ba20

commit d8ec73bfb3656cc89b7d7e848547312bcdf4ba20
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Fri Dec 14 11:39:43 2018

Revert "Add quota usage details tests for all other storage backends."

This reverts commit 548e7b5e622ad79155ff95ef26738d7a40fe9397.

Reason for revert: external/wpt/storage/estimate-usage-details-service-workers.https.tentative.window.html fails on Mac 10.13: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20(dbg)/7315

Original change's description:
> Add quota usage details tests for all other storage backends.
> 
> IndexedDB test was included in parent CL.
> 
> Bug: 904000
> Test: 
> Change-Id: Icc3462f13d0dce0197a8ec54f22d5ad794a51292
> Reviewed-on: https://chromium-review.googlesource.com/c/1334659
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Joshua Bell <jsbell@chromium.org>
> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616398}

TBR=jsbell@chromium.org,pwnall@chromium.org,jarrydg@chromium.org

Change-Id: Ibd83c1931cea3df81950eedcd4169585a68259ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 904000
Reviewed-on: https://chromium-review.googlesource.com/c/1377417
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616638}
[delete] https://crrev.com/baf8291abe913dd0ed101efb9ff060a91b46e04e/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details-application-cache.https.tentative.html
[delete] https://crrev.com/baf8291abe913dd0ed101efb9ff060a91b46e04e/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details-caches.https.tentative.any.js
[delete] https://crrev.com/baf8291abe913dd0ed101efb9ff060a91b46e04e/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details-service-workers.https.tentative.window.js
[delete] https://crrev.com/baf8291abe913dd0ed101efb9ff060a91b46e04e/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details.https.tentative.any.js
[delete] https://crrev.com/baf8291abe913dd0ed101efb9ff060a91b46e04e/third_party/blink/web_tests/external/wpt/storage/resources/appcache.manifest
[delete] https://crrev.com/baf8291abe913dd0ed101efb9ff060a91b46e04e/third_party/blink/web_tests/external/wpt/storage/resources/iframe_with_appcache_manifest.html

Comment 6 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1061788dd2c892de25e3817ef71dd779d57780da

commit 1061788dd2c892de25e3817ef71dd779d57780da
Author: Jarryd <jarrydg@chromium.org>
Date: Mon Dec 17 23:38:01 2018

Reland "Add quota usage details tests for all other storage backends."

This is a reland of 548e7b5e622ad79155ff95ef26738d7a40fe9397

Original change's description:
> Add quota usage details tests for all other storage backends.
> 
> IndexedDB test was included in parent CL.
> 
> Bug: 904000
> Test: 
> Change-Id: Icc3462f13d0dce0197a8ec54f22d5ad794a51292
> Reviewed-on: https://chromium-review.googlesource.com/c/1334659
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Joshua Bell <jsbell@chromium.org>
> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616398}

Bug: 904000
Change-Id: I507ec17eabc8e323a7c6418075d4be4787d4c5df
Reviewed-on: https://chromium-review.googlesource.com/c/1378805
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617285}
[add] https://crrev.com/1061788dd2c892de25e3817ef71dd779d57780da/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details-application-cache.https.tentative.html
[add] https://crrev.com/1061788dd2c892de25e3817ef71dd779d57780da/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details-caches.https.tentative.any.js
[add] https://crrev.com/1061788dd2c892de25e3817ef71dd779d57780da/third_party/blink/web_tests/external/wpt/storage/estimate-usage-details.https.tentative.any.js
[add] https://crrev.com/1061788dd2c892de25e3817ef71dd779d57780da/third_party/blink/web_tests/external/wpt/storage/resources/appcache.manifest
[add] https://crrev.com/1061788dd2c892de25e3817ef71dd779d57780da/third_party/blink/web_tests/external/wpt/storage/resources/iframe_with_appcache_manifest.html

Sign in to add a comment