New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903991 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Internal Cleanup - Remove multi-device flags from Instant Tethering

Project Member Reported by hsuregan@google.com, Nov 9

Issue description

The MultiDevice API replaces old methods.  Code that exists in Instant tethering which rely on eventually deprecated methods be removed, and MultiDevice flags should be removed as they will become the default.
 
Cc: jlklein@chromium.org jordynass@chromium.org khorimoto@chromium.org nohle@chromium.org jhawkins@chromium.org hansberry@chromium.org
Components: UI>Multidevice
Components: UI>Shell>Networking>Tethering
Cc: hsuregan@chromium.org
Owner: jhawkins@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62387c3f82ad9bc3b70bb5a7c7e813398a34f4bc

commit 62387c3f82ad9bc3b70bb5a7c7e813398a34f4bc
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Nov 13 19:51:12 2018

Instant Tethering: Remove kMultiDeviceApi flagging from HostScanSchedulerImpl.

R=hansberry@chromium.org

Bug:  903991 
Test: none
Change-Id: I85c5d0efcdf3c954d7756d2ca2952c06c56dd509
Reviewed-on: https://chromium-review.googlesource.com/c/1333899
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607711}
[modify] https://crrev.com/62387c3f82ad9bc3b70bb5a7c7e813398a34f4bc/chromeos/components/tether/host_scan_scheduler_impl.cc
[modify] https://crrev.com/62387c3f82ad9bc3b70bb5a7c7e813398a34f4bc/chromeos/components/tether/host_scan_scheduler_impl.h
[modify] https://crrev.com/62387c3f82ad9bc3b70bb5a7c7e813398a34f4bc/chromeos/components/tether/host_scan_scheduler_impl_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45c946c23519411c71518efff2110144211a794b

commit 45c946c23519411c71518efff2110144211a794b
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Nov 19 15:56:48 2018

Instant Tethering: Remove unused BleConnectionManager references.

Most of these stem from the root, MessageTransferOperation, which no
longer uses this passed-in parameter.

R=hansberry@chromium.org

Bug:  903991 
Test: none
Change-Id: Iedefb2a9cc56e922268aa0ddfec41eb310fc0709
Reviewed-on: https://chromium-review.googlesource.com/c/1340939
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609312}
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/asynchronous_shutdown_object_container.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/asynchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/asynchronous_shutdown_object_container_impl.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/connect_tethering_operation.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/connect_tethering_operation.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/connect_tethering_operation_unittest.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/disconnect_tethering_operation.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/disconnect_tethering_operation.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/disconnect_tethering_request_sender_impl.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/disconnect_tethering_request_sender_impl.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/fake_asynchronous_shutdown_object_container.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/fake_asynchronous_shutdown_object_container.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/host_connection_metrics_logger.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/host_connection_metrics_logger.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/host_connection_metrics_logger_unittest.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/host_scanner_impl.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/host_scanner_impl.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/host_scanner_impl_unittest.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/host_scanner_operation.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/host_scanner_operation.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/host_scanner_operation_unittest.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/keep_alive_operation.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/keep_alive_operation.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/keep_alive_operation_unittest.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/keep_alive_scheduler.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/keep_alive_scheduler.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/keep_alive_scheduler_unittest.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/message_transfer_operation.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/message_transfer_operation.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/message_transfer_operation_unittest.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/mock_host_connection_metrics_logger.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/mock_host_connection_metrics_logger.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/synchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/tether_connector_impl.cc
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/tether_connector_impl.h
[modify] https://crrev.com/45c946c23519411c71518efff2110144211a794b/chromeos/components/tether/tether_connector_impl_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6444cd5de4c2c467170efb5774d21fb48e88d0f6

commit 6444cd5de4c2c467170efb5774d21fb48e88d0f6
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Nov 20 03:53:35 2018

Instant Tethering: Remove unused BleAdvertiserImpl.

R=hansberry@chromium.org

Bug:  903991 
Test: none
Change-Id: I9445ee9d89a9381779dcbe1c0ffea703d9836cfb
Reviewed-on: https://chromium-review.googlesource.com/c/1343041
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609588}
[modify] https://crrev.com/6444cd5de4c2c467170efb5774d21fb48e88d0f6/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/6444cd5de4c2c467170efb5774d21fb48e88d0f6/chromeos/components/tether/asynchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/6444cd5de4c2c467170efb5774d21fb48e88d0f6/chromeos/components/tether/asynchronous_shutdown_object_container_impl.h
[modify] https://crrev.com/6444cd5de4c2c467170efb5774d21fb48e88d0f6/chromeos/components/tether/asynchronous_shutdown_object_container_impl_unittest.cc
[delete] https://crrev.com/1ec73a4fbc1863eeab9bd9e35d1c5be55c240809/chromeos/components/tether/ble_advertiser_impl.cc
[delete] https://crrev.com/1ec73a4fbc1863eeab9bd9e35d1c5be55c240809/chromeos/components/tether/ble_advertiser_impl.h
[delete] https://crrev.com/1ec73a4fbc1863eeab9bd9e35d1c5be55c240809/chromeos/components/tether/ble_advertiser_impl_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/534600afcef0b93a6b233d0442d2d043a867d317

commit 534600afcef0b93a6b233d0442d2d043a867d317
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Nov 20 03:57:42 2018

Instant Tethering: Remove unused BleScannerImpl.

R=hansberry@chromium.org

Bug:  903991 
Test: none
Change-Id: I51005dc78fc632371c1ad211fcafebfbdf730caf
Reviewed-on: https://chromium-review.googlesource.com/c/1343280
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609590}
[modify] https://crrev.com/534600afcef0b93a6b233d0442d2d043a867d317/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/534600afcef0b93a6b233d0442d2d043a867d317/chromeos/components/tether/asynchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/534600afcef0b93a6b233d0442d2d043a867d317/chromeos/components/tether/asynchronous_shutdown_object_container_impl.h
[modify] https://crrev.com/534600afcef0b93a6b233d0442d2d043a867d317/chromeos/components/tether/asynchronous_shutdown_object_container_impl_unittest.cc
[delete] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/chromeos/components/tether/ble_scanner_impl.cc
[delete] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/chromeos/components/tether/ble_scanner_impl.h
[delete] https://crrev.com/ec589a5ce0cd6d297605922119065cc2805d8db9/chromeos/components/tether/ble_scanner_impl_unittest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55e13e284d0b07b71e2be10607ae09b0b2220461

commit 55e13e284d0b07b71e2be10607ae09b0b2220461
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Nov 20 20:55:15 2018

Instant Tethering: Remove final kMultiDeviceApi flagging.

R=hansberry@chromium.org

Bug:  903991 
Test: none
Change-Id: Ifdeeb97fee9a964bca4fdeaece3df139e6c7584c
Reviewed-on: https://chromium-review.googlesource.com/c/1344250
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609793}
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/asynchronous_shutdown_object_container_impl_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/connect_tethering_operation_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/host_connection_metrics_logger_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/host_scan_scheduler_impl.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/host_scan_scheduler_impl_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/host_scanner_impl_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/host_scanner_operation_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/keep_alive_operation_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/keep_alive_scheduler_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/message_transfer_operation_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/tether_connector_impl_unittest.cc
[modify] https://crrev.com/55e13e284d0b07b71e2be10607ae09b0b2220461/chromeos/components/tether/tether_host_fetcher_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment