Issue 903978 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	tbansal@chromium.org
Closed:	Nov 13
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
M-72

Blocking:
issue 903945

Navigation Predictor: Exclude anchor elements from insecure frames in prediction

Project Member Reported by tbansal@chromium.org, Nov 9

Issue description

Make all predictions based on elements that are within the secure frames since it is unclear if we can pre* the target of the elements that are from insecure frame. Also, disregard anchor elements that point to insecure URLs.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7282b88b5dcbe6cf45b77298238ad7386abeefc8

commit 7282b88b5dcbe6cf45b77298238ad7386abeefc8
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Nov 13 01:39:50 2018

NavigationPredictor: Skip navigation prediction on insecure webpages

Change-Id: Ib7a70bf6d4921aafdd3786f7402f79547cee70de
Bug:  903978 
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1330338
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607416}
[modify] https://crrev.com/7282b88b5dcbe6cf45b77298238ad7386abeefc8/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/7282b88b5dcbe6cf45b77298238ad7386abeefc8/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
[modify] https://crrev.com/7282b88b5dcbe6cf45b77298238ad7386abeefc8/chrome/browser/navigation_predictor/navigation_predictor_unittest.cc

Comment 2 by tbansal@chromium.org, Nov 13

Labels: M-72
Status: Fixed (was: Started)

►

Issue 903978 link

Issue metadata

Navigation Predictor: Exclude anchor elements from insecure frames in prediction

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 13

Comment 1 Deleted

Comment 2 by tbansal@chromium.org, Nov 13

Comment 2 Deleted

Sign in to add a comment