New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 903972 link

Starred by 1 user
Status: Assigned
Owner:
wittman@chromium.org
Cc:
chengx@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Pontential jankiness caused by deserializing many call stack profiles at one time

Project Member Reported by chengx@chromium.org, Nov 9 
OS: Win, MacOS

We serialize all the call stack profiles in memory because this is memory efficient. We need to deserialize them when uploading them to UMA servers. Local test in my beefy corp machine shows deserializing a profile takes about 1 ms. In the extreme case where there are 1250 (due to a cap) profiles pending upload, serializing all of them in a row takes 1+ second. Since this is happening on UI thread, the jankiness can be a problem.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6efcf8ee5ff63171187abe90f296f106a440f34

commit b6efcf8ee5ff63171187abe90f296f106a440f34
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Nov 20 00:46:21 2018

Correct comments for kMaxPendingProfiles

Bug: 903972
Change-Id: Iba29af4d63e0e8dc68c728d0965e22c11bed8653
Reviewed-on: https://chromium-review.googlesource.com/c/1343354
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609535}
[modify] https://crrev.com/b6efcf8ee5ff63171187abe90f296f106a440f34/components/metrics/call_stack_profile_metrics_provider.cc

Comment 2 by chengx@chromium.org, Nov 22

Cc: -wittman@google.com chengx@google.com
Owner: wittman@chromium.org

Comment 3 by chengx@chromium.org, Nov 22

Cc: -chengx@google.com chengx@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9606c6d7592331575a7ff1130d6069c764d30c0e

commit 9606c6d7592331575a7ff1130d6069c764d30c0e
Author: Xi Cheng <chengx@chromium.org>
Date: Tue Nov 27 17:59:19 2018

Record the time cost of deserializing all pending call stack profiles

Bug: 903972
Change-Id: Ib70702de4cda80970454fd5d8c296855673698cb
Reviewed-on: https://chromium-review.googlesource.com/c/1347145
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611182}
[modify] https://crrev.com/9606c6d7592331575a7ff1130d6069c764d30c0e/components/metrics/call_stack_profile_metrics_provider.cc
[modify] https://crrev.com/9606c6d7592331575a7ff1130d6069c764d30c0e/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment