[animation worklet] KeyframeEffect constructor should be webexposed in AnimationWorklet OriginTrial |
|||||||||
Issue description
To create the basic AnimationWorklet example one needs to construct a KeyframeEffect [1]. KeyframeEffect constructor and all other WebAnimations APIs are behind WebAnimationsAPIs and currently not exposed when AnimationWorklet runtime enabled feature flag is set.
To fix this we have to set WebAnimationsAPI flag when AnimationWorklet flag is set.
[1]
new WorkletAnimation('foo', new KeyframeEffect(...keyframes), 1000).play();
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfa88e80c3052ed9f73cf98bf5a99d20feb17c32 commit cfa88e80c3052ed9f73cf98bf5a99d20feb17c32 Author: Majid Valipour <majidvp@chromium.org> Date: Mon Nov 12 16:28:36 2018 [animation-worklet] AnimationWorklet runtime flags should imply WebAnimationsAPI AnimationWorklet and ScrollTimeline heavily depend on WebAnimations API. For example to build the most basic example based on AnimationWorklet one needs to construct a KeyframeEffect. This CL will ensure that AnimationWorklet flag also enables WebAnimationsAPI runtime feature. Bug: 903953 , 811922 Change-Id: Ie1f92ee2e579541675f88b762cbc30895bc66942 Reviewed-on: https://chromium-review.googlesource.com/c/1329891 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#607250} [modify] https://crrev.com/cfa88e80c3052ed9f73cf98bf5a99d20feb17c32/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html [modify] https://crrev.com/cfa88e80c3052ed9f73cf98bf5a99d20feb17c32/third_party/blink/renderer/platform/runtime_enabled_features.json5
,
Nov 13
,
Nov 13
,
Nov 13
,
Nov 13
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 13
Requesting to Merge for M71. This change expands the scope of experimental features that are enabled by AnimationWorklet flag and related origin trial. Note that the change does not add any new functionality and the additional features are only exposed to Origin Trial participants. So it has very low risk. AnimationWorklet origin trial is expected to start in M71 and without this change the feature is not usage per #1. I tested this on latest chrome Canary (72.0.3610.0) on Linux and it works as expected. To test: 1) run latest Canary with the following flag: --enable-blink-features=AnimationWorklet 2) load https://animation-worklet-article.glitch.me/ 3) Expect to see two animated box moving across the screen.
,
Nov 13
Approving merge to M71 branch 3578 based on comment #7. Pls merge ASAP so we can pick it up for tomorrow's beta release, we're cutting RC soon today.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28a90438b5c0fc7fde25e94429608fee46b8a100 commit 28a90438b5c0fc7fde25e94429608fee46b8a100 Author: Majid Valipour <majidvp@chromium.org> Date: Tue Nov 13 15:34:04 2018 [animation-worklet] AnimationWorklet runtime flags should imply WebAnimationsAPI AnimationWorklet and ScrollTimeline heavily depend on WebAnimations API. For example to build the most basic example based on AnimationWorklet one needs to construct a KeyframeEffect. This CL will ensure that AnimationWorklet flag also enables WebAnimationsAPI runtime feature. Bug: 903953 , 811922 Change-Id: Ie1f92ee2e579541675f88b762cbc30895bc66942 Reviewed-on: https://chromium-review.googlesource.com/c/1329891 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607250}(cherry picked from commit cfa88e80c3052ed9f73cf98bf5a99d20feb17c32) Reviewed-on: https://chromium-review.googlesource.com/c/1333890 Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#657} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/28a90438b5c0fc7fde25e94429608fee46b8a100/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html [modify] https://crrev.com/28a90438b5c0fc7fde25e94429608fee46b8a100/third_party/blink/renderer/platform/runtime_enabled_features.json5
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28a90438b5c0fc7fde25e94429608fee46b8a100 Commit: 28a90438b5c0fc7fde25e94429608fee46b8a100 Author: majidvp@chromium.org Commiter: majidvp@chromium.org Date: 2018-11-13 15:34:04 +0000 UTC [animation-worklet] AnimationWorklet runtime flags should imply WebAnimationsAPI AnimationWorklet and ScrollTimeline heavily depend on WebAnimations API. For example to build the most basic example based on AnimationWorklet one needs to construct a KeyframeEffect. This CL will ensure that AnimationWorklet flag also enables WebAnimationsAPI runtime feature. Bug: 903953 , 811922 Change-Id: Ie1f92ee2e579541675f88b762cbc30895bc66942 Reviewed-on: https://chromium-review.googlesource.com/c/1329891 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607250}(cherry picked from commit cfa88e80c3052ed9f73cf98bf5a99d20feb17c32) Reviewed-on: https://chromium-review.googlesource.com/c/1333890 Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#657} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by majidvp@google.com
, Nov 9