New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 903948 link

Starred by 2 users
Status: Fixed
Owner:
eroman@chromium.org
Closed: Nov 29
Cc:
█ dcreager@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 837753



Sign in to add a comment

Reporting (from the renderer) fails when NetworkService is enabled

Project Member Reported by eroman@chromium.org, Nov 9 
When the renderer generates a deprecation or intervention report, it uses mojom::ReportingServiceProxy to queue it to the reporting service.

The receiving end looks to be running in the browser process as content::ReportingServiceProxyImpl (content/browser/net/), and tries to forward it to the reporting service hanging off the URLRequestContext. Which will presumably be missing when NetworkService is enabled:

https://chromium.googlesource.com/chromium/src/+/HEAD/content/browser/net/reporting_service_proxy.cc#132

Comment 1 by jam@chromium.org, Nov 13

Labels: -Pri-3 Proj-Servicification-Stable OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Thanks. Looks like we have NetworkContext::QueueReport recently, so we can use that interface always instead of reaching into net/ (it would work in both network service enabled and disabled).

Eric: do you have time to do this or should we find another owner?

Comment 2 by eroman@chromium.org, Nov 13

Owner: eroman@chromium.org
Status: Assigned (was: Untriaged)
Sure I can take this!

As you pointed out, it shouldn't be a big change.

Comment 3 by jam@chromium.org, Nov 14 

Thanks

Comment 4 by jam@chromium.org, Nov 26

Blocking: 837753

Comment 5 by dcreager@chromium.org, Nov 27

Cc: ddcreager@chromium.org

Comment 6 by dcreager@chromium.org, Nov 27

Cc: -ddcreager@chromium.org dcreager@chromium.org

Comment 7 by dougt@chromium.org, Nov 27

Labels: Hotlist-KnownIssue
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/218c5ce59314b0d17c45c37207640af0975ea3ba

commit 218c5ce59314b0d17c45c37207640af0975ea3ba
Author: Eric Roman <eroman@chromium.org>
Date: Thu Nov 29 18:03:13 2018

Use NetworkContext to queue reports.

Bug:  903948 
Change-Id: Ida8e955b212f26c9938a43cb196d9f90aac3404b
Reviewed-on: https://chromium-review.googlesource.com/c/1351098
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612271}
[modify] https://crrev.com/218c5ce59314b0d17c45c37207640af0975ea3ba/content/browser/net/reporting_service_proxy.cc
[modify] https://crrev.com/218c5ce59314b0d17c45c37207640af0975ea3ba/content/browser/net/reporting_service_proxy.h
[modify] https://crrev.com/218c5ce59314b0d17c45c37207640af0975ea3ba/content/browser/renderer_host/render_process_host_impl.cc

Comment 9 by eroman@chromium.org, Nov 29

Status: Fixed (was: Assigned)
►

Sign in to add a comment