Make tainted versions uploaded by gae.py have less collisions for demos |
|||
Issue descriptionNot sure what ths right component for this is. I think this is the function we're looking for: https://cs.chromium.org/chromium/infra/luci/appengine/components/tools/calculate_version.py?l=107 We frequently upload tainted versions of App Engine apps to give demos for UI changes. I think the tainted versions are computed from the upstream commit + the username of the person who uploaded it, so this means that if a user has simultaneous demos uploaded in a similar timeframe, the later demo can end up overwriting the older one. If possible, it'd be nice to switch the tainted version naming scheme to something that produces less collisions for demos. ie: Maybe using the local commit hash or including the branch name or something. Not sure what the right solution is here.
,
Nov 9
There's '-t' flag: "-t TAG, --tag=TAG Tag to attach to a tainted version" "gae.py upload -t blah" will produce version 2131-abcdef-blah-zhangtiff Is that enough?
,
Nov 9
Sure, I think we can work with the tag feature. Thanks for the quick response! I can make a CL to add this to Monorail's Makefile
,
Nov 15
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d077112910a23e6fa3d63aa040a820f313729bb1 commit d077112910a23e6fa3d63aa040a820f313729bb1 Author: Tiff Zhang <zhangtiff@google.com> Date: Thu Nov 15 17:08:34 2018 Monorail: Add branch name to demo name for make deploy_demo Bug: 903947 Change-Id: I0c78b8608cf1bd244894a0d672f6d7d3eb1a8488 Reviewed-on: https://chromium-review.googlesource.com/c/1329951 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> Cr-Commit-Position: refs/heads/master@{#19013} [modify] https://crrev.com/d077112910a23e6fa3d63aa040a820f313729bb1/appengine/monorail/Makefile |
|||
►
Sign in to add a comment |
|||
Comment 1 by zhangtiff@chromium.org
, Nov 9