New issue
Advanced search Search tips

Issue 903934 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 903632



Sign in to add a comment

compile failing on 2 builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 9

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of weiliangc@google.com

compile failing on 2 builders

Builders failed on: 
- GPU FYI Win Clang Builder (dbg): 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20FYI%20Win%20Clang%20Builder%20%28dbg%29
- GPU FYI Win x64 Builder (dbg): 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20FYI%20Win%20x64%20Builder%20%28dbg%29

Example failure:
[256/3562] LINK(DLL) skia_encoder_fuzzer_lib.dll skia_encoder_fuzzer_lib.dll.lib skia_encoder_fuzzer_lib.dll.pdb
FAILED: skia_encoder_fuzzer_lib.dll skia_encoder_fuzzer_lib.dll.lib skia_encoder_fuzzer_lib.dll.pdb 
ninja -t msvc -e environment.x64 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /IMPLIB:./skia_encoder_fuzzer_lib.dll.lib /DLL /OUT:./skia_encoder_fuzzer_lib.dll /PDB:./skia_encoder_fuzzer_lib.dll.pdb @./skia_encoder_fuzzer_lib.dll.rsp
lld-link: error: undefined symbol: "static void (__cdecl *const *const SkMatrix::gMapXYProcs)(class SkMatrix const &, float, float, struct SkPoint *)" (?gMapXYProcs@SkMatrix@@0QBQ6AXAEBV1@MMPEAUSkPoint@@@ZB)
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("static void (__cdecl * __cdecl SkMatrix::GetMapXYProc(enum SkMatrix::TypeMask))(class SkMatrix const &, float, float, struct SkPoint *)" (?GetMapXYProc@SkMatrix@@CAP6AXAEBV1@MMPEAUSkPoint@@@ZW4TypeMask@1@@Z))

lld-link: error: undefined symbol: "static void (__cdecl *const *const SkMatrix::gMapPtsProcs)(class SkMatrix const &, struct SkPoint *const, struct SkPoint const *const, int)" (?gMapPtsProcs@SkMatrix@@0QBQ6AXAEBV1@QEAUSkPoint@@QEBU2@H@ZB)
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("static void (__cdecl * __cdecl SkMatrix::GetMapPtsProc(enum SkMatrix::TypeMask))(class SkMatrix const &, struct SkPoint *const, struct SkPoint const *const, int)" (?GetMapPtsProc@SkMatrix@@CAP6AXAEBV1@QEAUSkPoint@@QEBU2@H@ZW4TypeMask@1@@Z))

lld-link: error: undefined symbol: "bool __cdecl SkStrEndsWith(char const *const, char const *const)" (?SkStrEndsWith@@YA_NQEBD0@Z)
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("bool __cdecl SkString::endsWith(char const *const) const" (?endsWith@SkString@@QEBA_NQEBD@Z))

lld-link: error: undefined symbol: "bool __cdecl SkStrEndsWith(char const *const, char)" (?SkStrEndsWith@@YA_NQEBDD@Z)
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("bool __cdecl SkString::endsWith(char) const" (?endsWith@SkString@@QEBA_ND@Z))

lld-link: error: undefined symbol: "void __cdecl Fuzz::nextRange(float *, float, float)" (?nextRange@Fuzz@@QEAAXPEAMMM@Z)
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("void __cdecl fuzz_WEBPEncoder(class Fuzz *)" (?fuzz_WEBPEncoder@@YAXPEAVFuzz@@@Z))

lld-link: error: undefined symbol: "void __cdecl Fuzz::next(bool *)" (?next@Fuzz@@QEAAXPEA_N@Z)
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("void __cdecl fuzz_WEBPEncoder(class Fuzz *)" (?fuzz_WEBPEncoder@@YAXPEAVFuzz@@@Z))

lld-link: error: undefined symbol: "struct _iobuf * __cdecl sk_fopen(char const *const, enum SkFILE_Flags)" (?sk_fopen@@YAPEAU_iobuf@@QEBDW4SkFILE_Flags@@@Z)
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("void __cdecl fuzz__MakeEncoderCorpus(class Fuzz *)" (?fuzz__MakeEncoderCorpus@@YAXPEAVFuzz@@@Z))

lld-link: error: undefined symbol: "unsigned __int64 __cdecl sk_fwrite(void const *, unsigned __int64, struct _iobuf *)" (?sk_fwrite@@YA_KPEBX_KPEAU_iobuf@@@Z)
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("void __cdecl fuzz__MakeEncoderCorpus(class Fuzz *)" (?fuzz__MakeEncoderCorpus@@YAXPEAVFuzz@@@Z))
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("void __cdecl fuzz__MakeEncoderCorpus(class Fuzz *)" (?fuzz__MakeEncoderCorpus@@YAXPEAVFuzz@@@Z))
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("void __cdecl fuzz__MakeEncoderCorpus(class Fuzz *)" (?fuzz__MakeEncoderCorpus@@YAXPEAVFuzz@@@Z))

lld-link: error: undefined symbol: "void __cdecl sk_fclose(struct _iobuf *)" (?sk_fclose@@YAXPEAU_iobuf@@@Z)
>>> referenced by obj/skia/skia_encoder_fuzzer_lib/FuzzEncoders.obj:("void __cdecl fuzz__MakeEncoderCorpus(class Fuzz *)" (?fuzz__MakeEncoderCorpus@@YAXPEAVFuzz@@@Z))


Suspect:
https://chromium-review.googlesource.com/c/chromium/src/+/1328225
  
 
Cc: kjlubick@chromium.org mtklein@chromium.org
Owner: metzman@chromium.org
Labels: Hotlist-PixelWrangler
just gonna to revert.
Cc: syoussefi@chromium.org
Blocking: 903632
Status: Fixed (was: Available)
Thank you Wei for taking care of this!

Sign in to add a comment