editing/pasteboard/drag-image-to-contenteditable-in-iframe.html and 23 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak |
|||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of flackr@chromium.org editing/pasteboard/drag-image-to-contenteditable-in-iframe.html and 23 other(s) in webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak Builders failed on: - WebKit Linux Trusty Leak: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak
,
Nov 9
Looks like this broke with https://chromium-review.googlesource.com/c/chromium/src/+/1265818
,
Nov 9
Created a revert at https://chromium-review.googlesource.com/c/chromium/src/+/1330329.
,
Nov 9
Sorry, I am looking into this. Thanks for creating a revert. This is related to https://crbug.com/903705
,
Nov 9
,
Nov 13
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a3ca40202b5875266f6eecbd7f5103363303302 commit 2a3ca40202b5875266f6eecbd7f5103363303302 Author: Darwin Huang <huangdarwin@chromium.org> Date: Wed Nov 21 11:31:09 2018 Drag and Drop: Frames not containing drag source shouldn't be able to reset drag state Only allow frames who are ancestors of the drag_src_ to reset a drag_src_ Created layout test to show previous lack of dragend when moving iframe in dom as a result of dragging Created layout test to verify lack of regression when frames containing drag source are moved/detached Fix memory leak from reverted CL https://crrev.com/c/1265818 Bug: 737691 , 903705 , 903933 Change-Id: I308680446662d6548587ae2d7dd2c139b09ee581 Reviewed-on: https://chromium-review.googlesource.com/c/1336440 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#610001} [add] https://crrev.com/2a3ca40202b5875266f6eecbd7f5103363303302/third_party/WebKit/LayoutTests/fast/dnd/dragtriggerdommove/drag-trigger-dom-move-iframe.html [add] https://crrev.com/2a3ca40202b5875266f6eecbd7f5103363303302/third_party/WebKit/LayoutTests/fast/dnd/dragtriggerdommove/drag-trigger-dom-move-image.html [add] https://crrev.com/2a3ca40202b5875266f6eecbd7f5103363303302/third_party/WebKit/LayoutTests/fast/dnd/dragtriggerdommove/drag-trigger-dom-move-nested-iframe.html [add] https://crrev.com/2a3ca40202b5875266f6eecbd7f5103363303302/third_party/WebKit/LayoutTests/fast/dnd/dragtriggerdommove/drag-trigger-dom-move-nested-iframes.html [add] https://crrev.com/2a3ca40202b5875266f6eecbd7f5103363303302/third_party/WebKit/LayoutTests/fast/dnd/resources/drag-trigger-dom-move.js [modify] https://crrev.com/2a3ca40202b5875266f6eecbd7f5103363303302/third_party/blink/renderer/core/frame/local_frame.cc [modify] https://crrev.com/2a3ca40202b5875266f6eecbd7f5103363303302/third_party/blink/renderer/core/input/mouse_event_manager.cc
,
Nov 21
Sorry for my memory leak/bad change, and thank you for reverting it for me so quickly. The change at #7 should resolve this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dtapu...@chromium.org
, Nov 9Status: Untriaged (was: Available)