LayerTreeHostContextTestLayersNotified test failures on Linux CFI bots |
|||
Issue descriptionFirst failing test: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11170 https://chromium-review.googlesource.com/c/chromium/src/+/1328965 reverted a direct composition change, but it's not responsible, and https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11217 and later builds which contain it also fail the test. Likely culprit is probably this cc change: https://chromium-review.googlesource.com/c/chromium/src/+/1318734 enne@ I can go ahead and revert your change unless you think it's a simple fix
,
Nov 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c193dc52f15d3173ae5ff07cf48aff260f1717d commit 0c193dc52f15d3173ae5ff07cf48aff260f1717d Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Sat Nov 10 01:14:02 2018 cc: Fix failing layer tree tests LayerTreeHostContextTestLayersNotified was changed recently to attach root layer after first activation, but it does a static_cast on impl layers before the layers are propagated to impl tree. Bug: 903931 Change-Id: I824a5fe5f9915156090098f7c8b2306c32a9db23 Reviewed-on: https://chromium-review.googlesource.com/c/1330722 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#607070} [modify] https://crrev.com/0c193dc52f15d3173ae5ff07cf48aff260f1717d/cc/trees/layer_tree_host_unittest_context.cc
,
Nov 14
Fixed now. Thanks, Sunny!
,
Nov 14
Issue 903843 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Nov 9