New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903931 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

LayerTreeHostContextTestLayersNotified test failures on Linux CFI bots

Project Member Reported by sunn...@chromium.org, Nov 9

Issue description

First failing test: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11170

https://chromium-review.googlesource.com/c/chromium/src/+/1328965 reverted a direct composition change, but it's not responsible, and https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11217 and later builds which contain it also fail the test.

Likely culprit is probably this cc change: https://chromium-review.googlesource.com/c/chromium/src/+/1318734

enne@ I can go ahead and revert your change unless you think it's a simple fix


 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e844c42a37cbe452e55f77acbe662892a44ad21

commit 6e844c42a37cbe452e55f77acbe662892a44ad21
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Fri Nov 09 20:27:12 2018

Reland "Reenable direct composition without video layers"

This reverts commit 6fb9951ce0f87e70b86cb5b12b4cca635341cbad.

Reason for revert: Not responsible for test failures. See  crbug.com/903931 

Original change's description:
> Revert "Reenable direct composition without video layers"
> 
> This reverts commit eec86ff6c03b228b426a4553c89724d04e0a0f56.
> 
> Reason for revert: Appears to break cc_unittests on the Linux CFI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11190
> 
> Original change's description:
> > Reenable direct composition without video layers
> > 
> > Reenable direct composition surface on devices without hardware overlays
> > since it enables other power improvements like flip mode swap chain and
> > disabling DWM redirection surface.
> > 
> > To mitigate the original concerns about direct composition, this change
> > makes DCLayerTree lazy initialize the video context and processor when
> > a video layer is first used.  On devices that don't support hardware
> > overlays, the video context and processor will never be initialized.
> > 
> > Bug:  894675 , 900702
> > Change-Id: I8c9d5b78718de2620ca177410d4916390e7cb219
> > Reviewed-on: https://chromium-review.googlesource.com/c/1318808
> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#606312}
> 
> TBR=dcheng@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  894675 , 900702
> Change-Id: I094721159277c50d9061dfded252bbac1084977f
> Reviewed-on: https://chromium-review.googlesource.com/c/1328965
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Commit-Queue: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606810}

TBR=dcheng@chromium.org,phoglund@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org

Change-Id: I47896832307fc7be15acfcefffe1953411e15cad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  894675 , 900702,  903931 
Reviewed-on: https://chromium-review.googlesource.com/c/1330284
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606951}
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/config/gpu_driver_bug_list.json
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/config/gpu_info.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/config/gpu_info.h
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/config/gpu_util.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/ipc/common/gpu_info.mojom
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/ipc/common/gpu_info_struct_traits.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/ipc/common/gpu_info_struct_traits.h
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/ipc/common/struct_traits_unittest.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/ipc/service/direct_composition_surface_win.h
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/gpu/ipc/service/image_transport_surface_win.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/ui/gl/gl_switches.cc
[modify] https://crrev.com/6e844c42a37cbe452e55f77acbe662892a44ad21/ui/gl/gl_switches.h

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c193dc52f15d3173ae5ff07cf48aff260f1717d

commit 0c193dc52f15d3173ae5ff07cf48aff260f1717d
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Sat Nov 10 01:14:02 2018

cc: Fix failing layer tree tests

LayerTreeHostContextTestLayersNotified was changed recently to attach
root layer after first activation, but it does a static_cast on impl
layers before the layers are propagated to impl tree.

Bug:  903931 
Change-Id: I824a5fe5f9915156090098f7c8b2306c32a9db23
Reviewed-on: https://chromium-review.googlesource.com/c/1330722
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607070}
[modify] https://crrev.com/0c193dc52f15d3173ae5ff07cf48aff260f1717d/cc/trees/layer_tree_host_unittest_context.cc

Status: Fixed (was: Assigned)
Fixed now.  Thanks, Sunny!
Cc: enne@chromium.org japhet@chromium.org petermayo@chromium.org tasak@chromium.org
 Issue 903843  has been merged into this issue.

Sign in to add a comment