New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 903924 link

Starred by 1 user
Status: Untriaged
Owner:
█ rmrossi@chromium.org
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Chromevox background script fails on chromecast

Project Member Reported by rmrossi@chromium.org, Nov 9 
Chromevox running on Google Home Hub is currently broken.

The chrome.audio API is only available on chrome os and its use is causing an exception on chromecast.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a19f56060da9c33897df3d9911e6e474aa554f9

commit 1a19f56060da9c33897df3d9911e6e474aa554f9
Author: Randy Rossi <rmrossi@chromium.org>
Date: Mon Nov 19 16:19:49 2018

Guard chrome.audio usage with check

chrome.audio is not available on chromecast. This caused
the background script to stop working.  Adding a guard
to make sure the api is available before use.

Test: Manual
Bug: 903924
Change-Id: I9f162d2f80074e72e44deca6d2893255fff37d2e
Reviewed-on: https://chromium-review.googlesource.com/c/1330220
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609319}
[modify] https://crrev.com/1a19f56060da9c33897df3d9911e6e474aa554f9/chrome/browser/resources/chromeos/chromevox/cvox2/background/next_earcons.js
►

Sign in to add a comment