New issue
Advanced search Search tips

Issue 903916 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 902897
Owner: ----
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Swipe down to minimize not working if tab is not at newtab

Project Member Reported by xiy...@chromium.org, Nov 9

Issue description

Found on r606182. 

What steps will reproduce the problem?
(1) Open a browser window and navigate away from new tab page
    e.g. go to "google.com";
(2) Swipe down on the tab in tab strip;

What is the expected result?
The tab is minimized.


What happens instead?
The tab is minimized then restored. See attached video.

The problem seems to be at TabDragController::RestoreFocus [1] called from TabDragController::EndDragImpl. When we are not in newtab page, FocusLocationBarByDefault returns false and we would focus on the content area which would activate the browser window.

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_drag_controller.cc?rcl=19b5cacda30456a0375495f85d3840953b156eef&l=665



 
swipe_down_minimize_not_working.webm
1.5 MB View Download
Cc: mukai@chromium.org est...@chromium.org
Mergedinto: 902897
Status: Duplicate (was: Untriaged)
I've noticed this recently. Deduping...

Sign in to add a comment