New issue
Advanced search Search tips

Issue 903894 link

Starred by 3 users
Status: Fixed
Owner:
ma...@igalia.com
Closed: Nov 13
Cc:
blundell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/ui/webui/app_launcher_login_handler.cc to Identity service

Project Member Reported by ma...@igalia.com, Nov 9 
APIs used:
  - SigninManagerBase::GetAuthenticatedAccountInfo
  - SigninManagerBase::IsSigninAllowed() --> see  crbug.com/889863

Comment 1 by blundell@chromium.org, Nov 12

Blocking: 883330
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)

Comment 2 by blundell@chromium.org, Nov 12 

 Issue 890805  has been merged into this issue.

Comment 3 by ma...@igalia.com, Nov 12

Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d0e63da2c7135c1e80ff8e62bffecfc046eddd

commit 10d0e63da2c7135c1e80ff8e62bffecfc046eddd
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Tue Nov 13 18:54:59 2018

Convert chrome/browser/ui/webui/app_launcher_login_handler.cc to Identity service

Migrate uses of SigninManagerBase's GetAuthenticatedAccountInfo()
and IsSigninAllowed() to the Identity Manager.

Bug:  903894 
Change-Id: Idcddc8adffbdb4093df7170551403ae20a14afe7
Reviewed-on: https://chromium-review.googlesource.com/c/1329979
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607679}
[modify] https://crrev.com/10d0e63da2c7135c1e80ff8e62bffecfc046eddd/chrome/browser/ui/webui/app_launcher_login_handler.cc

Comment 6 by ma...@igalia.com, Nov 13

Status: Fixed (was: Started)
►

Sign in to add a comment