Convert chrome/browser/ui/autofill/chrome_autofill_client.cc to Identity service |
||||
Issue descriptionAPIs used: - SigninManagerBase::GetAuthenticatedAccountId()
,
Nov 12
,
Nov 13
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d8fb7322d2ee3652ed38c2a380c252549b9d698 commit 1d8fb7322d2ee3652ed38c2a380c252549b9d698 Author: Mario Sanchez Prada <mario@igalia.com> Date: Tue Nov 13 17:23:26 2018 Convert chrome/browser/ui/autofill/chrome_autofill_client.cc to Identity service Migrated away from SigninManagerBase::GetAuthenticatedAccountId() and AccountTrackerService::GetAccountInfo(), to rely on the IdentityManager. Bug: 903886 Change-Id: I4bd70c490760a9d22687545f7d22851f9cdb9a5a Reviewed-on: https://chromium-review.googlesource.com/c/1331473 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#607632} [modify] https://crrev.com/1d8fb7322d2ee3652ed38c2a380c252549b9d698/chrome/browser/ui/autofill/chrome_autofill_client.cc
,
Nov 13
Is there any behavior change associated with this migration?
,
Nov 13
> Is there any behavior change associated with this migration? There shouldn't be any, since IdentityManager is a new API that relies underneath on the SigninManager and AccountTrackerService APIs (and other related APIS, such as OAuth2TokenService).
,
Nov 14
@sebsg: Confirming Mario's response; no, there won't be any behavioral change.
,
Nov 14
Thanks both for confirming! |
||||
►
Sign in to add a comment |
||||
Comment 1 by blundell@chromium.org
, Nov 12Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)