New issue
Advanced search Search tips

Issue 903886 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/ui/autofill/chrome_autofill_client.cc to Identity service

Project Member Reported by ma...@igalia.com, Nov 9

Issue description

APIs used:
  - SigninManagerBase::GetAuthenticatedAccountId()

 
Blocking: 883330
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)
Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d8fb7322d2ee3652ed38c2a380c252549b9d698

commit 1d8fb7322d2ee3652ed38c2a380c252549b9d698
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Tue Nov 13 17:23:26 2018

Convert chrome/browser/ui/autofill/chrome_autofill_client.cc to Identity service

Migrated away from SigninManagerBase::GetAuthenticatedAccountId() and
AccountTrackerService::GetAccountInfo(), to rely on the IdentityManager.

Bug:  903886 
Change-Id: I4bd70c490760a9d22687545f7d22851f9cdb9a5a
Reviewed-on: https://chromium-review.googlesource.com/c/1331473
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607632}
[modify] https://crrev.com/1d8fb7322d2ee3652ed38c2a380c252549b9d698/chrome/browser/ui/autofill/chrome_autofill_client.cc

Cc: se...@chromium.org
Is there any behavior change associated with this migration?
Status: Fixed (was: Started)
> Is there any behavior change associated with this migration?

There shouldn't be any, since IdentityManager is a new API that relies underneath on the SigninManager and AccountTrackerService APIs (and other related APIS, such as OAuth2TokenService).
@sebsg: Confirming Mario's response; no, there won't be any behavioral change.
Thanks both for confirming!

Sign in to add a comment