New issue
Advanced search Search tips

Issue 903878 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc to Identity service

Project Member Reported by ma...@igalia.com, Nov 9

Issue description

APIs used:
  - SigninManagerBase::SetAuthenticatedAccountInfo
 
Blocking: 883330
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)
Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2f53fd76e9823af6d9623861fabf24a120bcd90

commit e2f53fd76e9823af6d9623861fabf24a120bcd90
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Nov 28 15:07:47 2018

[s13n] Convert c/b/safe_browsing/chrome_password_protection_service_unittest.cc to IdentityManager

Note that the CL is able to use gaia IDs from AccountInfo, rather than hardcode them.

BUG= 903878 

Change-Id: I03dd2f0bd271e969be00aa23005a6bd8960062e0
Reviewed-on: https://chromium-review.googlesource.com/c/1351157
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611693}
[modify] https://crrev.com/e2f53fd76e9823af6d9623861fabf24a120bcd90/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment