New issue
Advanced search Search tips

Issue 903874 link

Starred by 1 user
Status: Fixed
Owner:
verwa...@chromium.org
Closed: Nov 13
Cc:
adamk@chromium.org
marja@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Stack-overflow in v8::internal::ParserBase<v8::internal::PreParser>::ParseObjectPropertyDefinition

Project Member Reported by ClusterFuzz, Nov 9 
Detailed report: https://clusterfuzz.com/testcase?key=6049783258808320

Fuzzer: ifratric_pdf_generic
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: Stack-overflow
Crash Address: 0x7ffc15d5fb78
Crash State:
  v8::internal::ParserBase<v8::internal::PreParser>::ParseObjectPropertyDefinition
  v8::internal::ParserBase<v8::internal::PreParser>::ParseObjectLiteral
  v8::internal::ParserBase<v8::internal::PreParser>::ParseBindingPattern
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6049783258808320

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
Project Member

Comment 1 by ClusterFuzz, Nov 9

Components: Blink>JavaScript>Parser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by adamk@chromium.org, Nov 9

Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)
I would be shocked if this were not related to verwaest's work :)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bc534453973eae78b672a5fa75ead3e5172a0763

commit bc534453973eae78b672a5fa75ead3e5172a0763
Author: Toon Verwaest <verwaest@chromium.org>
Date: Mon Nov 12 09:15:45 2018

[parser] Check stackoverflow in ParseBindingPattern

Bug:  chromium:903874 
Change-Id: If9828ae206b9bc1407e7d3f217d5fb894a4fe747
Reviewed-on: https://chromium-review.googlesource.com/c/1329688
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57420}
[modify] https://crrev.com/bc534453973eae78b672a5fa75ead3e5172a0763/src/parsing/parser-base.h
[add] https://crrev.com/bc534453973eae78b672a5fa75ead3e5172a0763/test/message/regress/fail/regress-903874.js
[add] https://crrev.com/bc534453973eae78b672a5fa75ead3e5172a0763/test/message/regress/fail/regress-903874.out

Comment 4 by verwa...@chromium.org, Nov 13

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Nov 20

Labels: Needs-Feedback
ClusterFuzz testcase 6049783258808320 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
►

Sign in to add a comment