New issue
Advanced search Search tips

Issue 903865 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc to Identity service

Project Member Reported by ma...@igalia.com, Nov 9

Issue description

APIs used:
  - SigninManagerBase::SetAuthenticatedAccountInfo()

 
Blocking: 883330
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)
Owner: svil...@igalia.com
Status: Started (was: Available)
Starting this
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6aabbdc5e063b44e91c8092f05d26b78fa46240

commit a6aabbdc5e063b44e91c8092f05d26b78fa46240
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Wed Nov 28 09:08:39 2018

Convert signed_in_devices_manager_unittest.cc to identity service

It was using the SigninManager API to the set authenticated (primary)
account. It was also using an ad-hoc TestingProfile. From now on the
profile is created using IdentityTestEnvironmentProfileAdaptor and the
IdentityTestEnvironment owned by the adaptor is used to set the
primary account.

Bug:  903865 
Change-Id: I1313f11fbbe1121afb755c1723c8a822747dea6c
Reviewed-on: https://chromium-review.googlesource.com/c/1349697
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611608}
[modify] https://crrev.com/a6aabbdc5e063b44e91c8092f05d26b78fa46240/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

Status: Fixed (was: Started)
Closing bug

Sign in to add a comment