The bottom toolbar refactoring CL: https://chromium-review.googlesource.com/c/chromium/src/+/1292405 introduced a new home button component: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/toolbar/HomeButton.java We should re-use this class in the top toolbar.
I think this is a duplicate of issue 871806... or maybe a child of 871806.
Made it a child
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e61ed440b524d16bfb163c8fbe8f585aef30dd20 commit e61ed440b524d16bfb163c8fbe8f585aef30dd20 Author: Pedro Amaral <amaralp@chromium.org> Date: Wed Nov 28 00:33:14 2018 Unify home button across top and bottom toolbars Bug: 903864 Change-Id: I7110ee2b0e6eab650d9388c828738ad349e20cc2 Reviewed-on: https://chromium-review.googlesource.com/c/1340791 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#611455} [modify] https://crrev.com/e61ed440b524d16bfb163c8fbe8f585aef30dd20/chrome/android/java/res/layout/bottom_toolbar_browsing.xml [modify] https://crrev.com/e61ed440b524d16bfb163c8fbe8f585aef30dd20/chrome/android/java/res/layout/toolbar_phone.xml [modify] https://crrev.com/e61ed440b524d16bfb163c8fbe8f585aef30dd20/chrome/android/java/res/layout/toolbar_tablet.xml [add] https://crrev.com/e61ed440b524d16bfb163c8fbe8f585aef30dd20/chrome/android/java/src/org/chromium/chrome/browser/toolbar/HomeButton.java [delete] https://crrev.com/13e562fdaba2a68835ba1894a39eb71bd43dac63/chrome/android/java/src/org/chromium/chrome/browser/toolbar/HomePageButton.java [modify] https://crrev.com/e61ed440b524d16bfb163c8fbe8f585aef30dd20/chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BrowsingModeBottomToolbarCoordinator.java [delete] https://crrev.com/13e562fdaba2a68835ba1894a39eb71bd43dac63/chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/HomeButton.java [modify] https://crrev.com/e61ed440b524d16bfb163c8fbe8f585aef30dd20/chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarLayout.java [modify] https://crrev.com/e61ed440b524d16bfb163c8fbe8f585aef30dd20/chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java [modify] https://crrev.com/e61ed440b524d16bfb163c8fbe8f585aef30dd20/chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarTablet.java [modify] https://crrev.com/e61ed440b524d16bfb163c8fbe8f585aef30dd20/chrome/android/java_sources.gni
Comment 1 by twelling...@chromium.org
, Nov 12