New issue
Advanced search Search tips

Issue 903863 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Convert chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc to the Identity service

Project Member Reported by ma...@igalia.com, Nov 9

Issue description

APIs used:
  - SigninManagerBase::SetAuthenticatedAccountInfo()

 
Blocking: 883330
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)
Owner: svil...@igalia.com
Status: Started (was: Available)
Checking this
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3419b503a760bed9650f3ba98c7a1187e6b78c59

commit 3419b503a760bed9650f3ba98c7a1187e6b78c59
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Mon Nov 26 10:59:41 2018

Convert enterprise_platform_keys_api_unittest.cc to the Identity service

It was using the SigninManager to set the authenticated (primary)
account. Replaced by a call to the identity API.

Bug:  903863 
Change-Id: Ib82685ddd13e907d8f318e3079207763fd3c9f51
Reviewed-on: https://chromium-review.googlesource.com/c/1348329
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610805}
[modify] https://crrev.com/3419b503a760bed9650f3ba98c7a1187e6b78c59/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
[modify] https://crrev.com/3419b503a760bed9650f3ba98c7a1187e6b78c59/services/identity/public/cpp/identity_test_utils.cc
[modify] https://crrev.com/3419b503a760bed9650f3ba98c7a1187e6b78c59/services/identity/public/cpp/identity_test_utils.h

Status: Fixed (was: Started)
Done

Sign in to add a comment