Convert chrome/browser/extensions/api/browsing_data/browsing_data_test.cc to the Identity service |
||||||||
Issue descriptionAPIs used: - SigninManagerBase::SetAuthenticatedAccountInfo() - ProfileOAuth2TokenService::UpdateCredentials() - ProfileOAuth2TokenService::RefreshTokenIsAvailable() - ProfileOAuth2TokenService::GetAuthError() - ProfileOAuth2TokenService::GetDelegate()->UpdateAuthError()
,
Nov 27
,
Nov 27
,
Nov 27
,
Nov 27
Lets discuss and agree on the blockers first.
,
Nov 27
,
Nov 28
Blockers make sense to me! I updated the GetAuthError() bug, so someone can get started on that one.
,
Dec 11
Working out a CL here on top of https://crrev.com/c/1362902 (Mario's).
,
Dec 11
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ae1b05b181311ccf89c4b89d45de523bbf1edbf commit 7ae1b05b181311ccf89c4b89d45de523bbf1edbf Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Dec 12 23:28:25 2018 [s13n] Convert c/b/extensions/api/browsing_data/browsing_data_test.cc to Identity service CL uses IdentityManager API instead of using the soon to be private ProfileOAuth2TokenService and SigninManage APIs. BUG= 903862 Change-Id: Icb817cd1110d777b3cc2ceb8a4888ffe83d93abb Reviewed-on: https://chromium-review.googlesource.com/c/1372425 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#616103} [modify] https://crrev.com/7ae1b05b181311ccf89c4b89d45de523bbf1edbf/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
,
Dec 12
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by blundell@chromium.org
, Nov 12Blocking: 883330 883318
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)