New issue
Advanced search Search tips

Issue 903859 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 904404

Blocking:
issue 883318
issue 883330



Sign in to add a comment

Convert chrome/browser/browsing_data/browsing_data_remover_browsertest.cc to Identity service

Project Member Reported by ma...@igalia.com, Nov 9

Issue description

APIs used:
  - GetAuthenticatedAccountId()
  - SetAuthenticatedAccountInfo()
 
Blockedon: 904404
Blocking: 883330 883318
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)
The browsertest uses ProfileOAuth2TokenService as well.
This file can be converted to use the functions of identity_test_utils.h; the removal of SigninManager/ProfileOAuth2TokenService knowledge will then happen when the blocking bug is fixed. (i.e., we can convert this file even before the blocking bug is fixed).
Owner: svil...@igalia.com
Status: Started (was: Available)
Taking this then...
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6265954497afc6dc62d847e72b3219bf611275e6

commit 6265954497afc6dc62d847e72b3219bf611275e6
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Wed Nov 28 19:31:43 2018

Convert browsing_data_remover_browsertest.cc to Identity service

Replaced the usage of ProfileOAuth2TokenService and SigninManager by
identity API calls.

This CL adds a new function to the identity_test_utils.h set to set
the auth error of a given account with a refresh token.

Bug:  903859 
Change-Id: I29e1ae3bee6ba7f69404f5f2bb7152fa0db9101d
Reviewed-on: https://chromium-review.googlesource.com/c/1352250
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611821}
[modify] https://crrev.com/6265954497afc6dc62d847e72b3219bf611275e6/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/6265954497afc6dc62d847e72b3219bf611275e6/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/6265954497afc6dc62d847e72b3219bf611275e6/services/identity/public/cpp/identity_test_utils.cc
[modify] https://crrev.com/6265954497afc6dc62d847e72b3219bf611275e6/services/identity/public/cpp/identity_test_utils.h

Status: Fixed (was: Started)

Sign in to add a comment