Convert chrome/browser/ui/webui/print_preview/print_preview_handler.cc to IdentityManager |
|||||||
Issue descriptionAPIs used: - GetAuthenticatedAccountId() Also, PrintPreviewHandler::AccessTokenService implements OAuth2TokenService::Consumer, so that's probably a good candidate to migrate
,
Nov 12
,
Nov 12
,
Nov 20
I guess this block makes the migration slightly harder:
(...)
} else if (type == "device") {
#if defined(OS_CHROMEOS)
chromeos::DeviceOAuth2TokenService* token_service =
chromeos::DeviceOAuth2TokenServiceFactory::Get();
account_id = token_service->GetRobotAccountId();
service = token_service;
#endif
Sylvain, Colin: WDYT?
,
Nov 21
,
Nov 21
Yes, absolutely! I made a bug to block this. I'll need to create a solution for this use case first.
,
Dec 3
This bug is free to take now; see the solution in the blocking bug.
,
Jan 8
,
Jan 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b5ce1f5f57a8a402f5586e8275f4469cc24e184 commit 7b5ce1f5f57a8a402f5586e8275f4469cc24e184 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Sat Jan 12 07:55:04 2019 Convert print_preview_handler.cc to IdentityManager ProfileOAuth2TokenService is replaced with PrimaryAccountAccessTokenFetcher. DeviceOAuth2TokenService is kept and its usage inlined as per the discussion in https://crbug.com/907540 . Bug: 903857 Change-Id: Id242fd6885ca513bba557fabb2d2bfd7bda46511 Reviewed-on: https://chromium-review.googlesource.com/c/1402797 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#622297} [modify] https://crrev.com/7b5ce1f5f57a8a402f5586e8275f4469cc24e184/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
,
Jan 14
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ma...@igalia.com
, Nov 12