New issue
Advanced search Search tips

Issue 903846 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[ios] Remove stale includes and dependencies on //components/signin/core/browser from //ios

Project Member Reported by ma...@igalia.com, Nov 9

Issue description

As part of the servicification project and the migration to the Identity service (and also sometimes as consequences of previous changes), we have removed dependencies on //components/signin/core/browser from many places, but some stale includes and dependencies remained.

This ticket is to tackle a final cleanup process over those files on iOS that have been already migrated to the Identity service.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d1f705299bffc64ae4a85b748266581ac07a695

commit 0d1f705299bffc64ae4a85b748266581ac07a695
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Sat Nov 10 10:03:37 2018

[ios] Remove stale includes/dependencies on //components/signin/core/browser

As part of the servicification project and the migration to the Identity
service, we have removed dependencies on //components/signin/core/browser
from many places, but some stale includes and dependencies remained.

This patch attempts to clean that up so that we have a better and cleaner
surface to work upon when doing the servicification.

Bug:  903846 
Change-Id: I1f28f1c08047c279dcad60cff4e66945d4e68852
Reviewed-on: https://chromium-review.googlesource.com/c/1329923
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607119}
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/autofill/personal_data_manager_factory.cc
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/gcm/BUILD.gn
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/gcm/ios_chrome_gcm_profile_service_factory.cc
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/history/BUILD.gn
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/history/web_history_service_factory.cc
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/invalidation/BUILD.gn
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/invalidation/ios_chrome_deprecated_profile_invalidation_provider_factory.mm
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/sync/BUILD.gn
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/ui/first_run/BUILD.gn
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/ui/first_run/first_run_egtest.mm
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/ui/settings/signin_settings_egtest.mm
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/ui/signin_interaction/BUILD.gn
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest.mm
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/web_view/internal/autofill/web_view_personal_data_manager_factory.cc
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/web_view/internal/signin/web_view_identity_manager_factory.mm
[modify] https://crrev.com/0d1f705299bffc64ae4a85b748266581ac07a695/ios/web_view/internal/sync/web_view_profile_invalidation_provider_factory.mm

Status: Fixed (was: Started)

Sign in to add a comment