New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903843 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 903931
Owner:
Closed: Nov 14
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

root layer re-use/presumption in LTHC tests

Project Member Reported by petermayo@chromium.org, Nov 9

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/1318734 causes Linux/Android CFI Build failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11170

cc_unittests Run on OS: 'Ubuntu-14.04'
Shard duration: 0:01:15.771606
failures:
LayerTreeHostContextTestLayersNotified.RunSingleThread_DelegatingRenderer
LayerTreeHostContextTestLayersNotified.RunMultiThread_DelegatingRenderer

--
"LayerTreeHostContextTest::SetupTree();" uses layer_tree_host()->root_layer(): i.e.

  void LayerTreeTest::SetupTree() {
    if (!layer_tree_host()->root_layer()) {
      scoped_refptr<Layer> root_layer = Layer::Create();
      root_layer->SetBounds(gfx::Size(1, 1));
      layer_tree_host()->SetRootLayer(root_layer);
    }

However, layer_tree_host()->SetRootLayer(root_); was removed, another root layer is created.
So using the root layer to "ReuseOrCreateLayerImpl", cc::LayerImpl's instance is created. Casting the instance as cc::FakePictureLayerImpl is not allowed:

../../cc/trees/layer_tree_host_unittest_context.cc:836:20: runtime error: control flow integrity check for type 'cc::FakePictureLayerImpl' failed during base-to-derived cast (vtable address 0x55da84fe2fa0)
0x55da84fe2fa0: note: vtable is of type 'cc::LayerImpl'
 da 55 00 00  b0 32 2c 84 da 55 00 00  b0 34 2c 84 da 55 00 00  10 39 2c 84 da 55 00 00  70 b9 83 83
              ^
    #0 0x55da83ca67dd in cc::(anonymous namespace)::LayerTreeHostContextTestLayersNotified::DidActivateTreeOnThread(cc::LayerTreeHostImpl*) ./../../cc/trees/layer_tree_host_unittest_context.cc:836:20
    #1 0x55da844000f4 in cc::LayerTreeHostImplForTesting::ActivateSyncTree() ./../../cc/test/layer_tree_test.cc:328:18
 
Labels: -OS-Chrome
Owner: enne@chromium.org
enne@, would you take a look?
Status: Assigned (was: Available)
Labels: -Sheriff-Chromium
Mergedinto: 903931
Status: Duplicate (was: Assigned)

Sign in to add a comment