Hide keyboard accessory if content area is too small |
|||
Issue descriptionIf the content area is smaller than 80dp in height or 300dp in width, hide the keyboard accessory.
,
Nov 13
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73b488158ac6d9426c8e0ff2f8f65e8026608705 commit 73b488158ac6d9426c8e0ff2f8f65e8026608705 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Thu Nov 15 13:08:11 2018 [Mfill Android] Hide keyboard accessory if content area is too small Whenever the layout is invoked, check whether the available content area falls below 80dp (doesn't include height of accessory). If that condition is met, hide the accessory. This ensures that the accessory doesn't consume all screen space that is left on small devices, or large keyboards in horizontal mode. Bug: 903841 Change-Id: I9a6ea1dfea61353206edaab4f2d5567b830b6f24 Reviewed-on: https://chromium-review.googlesource.com/c/1333753 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#608341} [modify] https://crrev.com/73b488158ac6d9426c8e0ff2f8f65e8026608705/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java [modify] https://crrev.com/73b488158ac6d9426c8e0ff2f8f65e8026608705/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java [modify] https://crrev.com/73b488158ac6d9426c8e0ff2f8f65e8026608705/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
,
Nov 15
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3949b638010ae8d99a64b75051033538a803b20 commit d3949b638010ae8d99a64b75051033538a803b20 Author: Ioana Pandele <ioanap@chromium.org> Date: Thu Nov 29 21:28:41 2018 Lower min required content area width for showing the keyboard accessory Bug: 903841 Change-Id: I7cfaac674593dc5786afe05aee988d2800c7886d Reviewed-on: https://chromium-review.googlesource.com/c/1355186 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#612354} [modify] https://crrev.com/d3949b638010ae8d99a64b75051033538a803b20/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java [modify] https://crrev.com/d3949b638010ae8d99a64b75051033538a803b20/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java |
|||
►
Sign in to add a comment |
|||
Comment 1 by fhorschig@chromium.org
, Nov 9