New issue
Advanced search Search tips

Issue 903840 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Convert ios/chrome/browser/ui/bookmarks/synced_bookmarks_bridge.mm to IdentityManager

Project Member Reported by ma...@igalia.com, Nov 9

Issue description

API used:
  - IsAuthenticated()
 
Blocking: 883330
Status: Available (was: Untriaged)
Labels: -Pri-3 Pri-1
Owner: ma...@igalia.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa24463770d4c005dbc1551f0826591b13b1b69

commit dfa24463770d4c005dbc1551f0826591b13b1b69
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Tue Nov 13 17:53:59 2018

Migrate SyncedBookmarksObserverBridge to the IdentityManager

Replace usage of SigninManagerBase::IsAuthenticated with
IdentityManager::HasPrimaryAccount().

Bug:  903840 
Change-Id: I907301ebe26df1a1b7c718a30ec0051b26a5ad55
Reviewed-on: https://chromium-review.googlesource.com/c/1332300
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607645}
[modify] https://crrev.com/dfa24463770d4c005dbc1551f0826591b13b1b69/ios/chrome/browser/ui/bookmarks/synced_bookmarks_bridge.h
[modify] https://crrev.com/dfa24463770d4c005dbc1551f0826591b13b1b69/ios/chrome/browser/ui/bookmarks/synced_bookmarks_bridge.mm

Status: Fixed (was: Started)

Sign in to add a comment