New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903837 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Consider removing display_linear-rgb.html LayoutTest

Project Member Reported by mcasas@chromium.org, Nov 9

Issue description

crrev.com/c/1130170 removes an |image_id| member and somehow
that rubs the mentioned LayoutTest the wrong way (but loading
the html itself works on Chrome). Regardless, there's a good
chance of Chrome removing support for linear RGB colorspace,
so for the time being just disable this test.
 
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb51ccdee421f37d7ed1ec897dc7aea504b6ef6

commit cfb51ccdee421f37d7ed1ec897dc7aea504b6ef6
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Nov 09 19:28:28 2018

CanvasResourceGpuMemoryBuffer: remove |image_id_| member

This CL follows crrev.com/c/1056168 and removes |image_id_| from
CanvasResourceGpuMemoryBuffer, since it's not needed (it was
mentioned in that CL description but finally not removed).

Bug: 839970, 903837
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7540363f131e3a33609c945e68c8106992e0ba77
Reviewed-on: https://chromium-review.googlesource.com/c/1130170
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606927}
[modify] https://crrev.com/cfb51ccdee421f37d7ed1ec897dc7aea504b6ef6/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/cfb51ccdee421f37d7ed1ec897dc7aea504b6ef6/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[modify] https://crrev.com/cfb51ccdee421f37d7ed1ec897dc7aea504b6ef6/third_party/blink/renderer/platform/graphics/canvas_resource.cc
[modify] https://crrev.com/cfb51ccdee421f37d7ed1ec897dc7aea504b6ef6/third_party/blink/renderer/platform/graphics/canvas_resource.h

Sign in to add a comment