New issue
Advanced search Search tips

Issue 903835 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Convert ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc to IdentityManager

Project Member Reported by ma...@igalia.com, Nov 9

Issue description

API used:
  - GetAuthenticatedAccountId()

 
Summary: Convert chrome/browser/browser_state/chrome_browser_state_manager_impl.cc to IdentityManager (was: Convert chrome_browser_state_manager_impl.cc to IdentityManager)
Summary: Convert ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc to IdentityManager (was: Convert chrome/browser/browser_state/chrome_browser_state_manager_impl.cc to IdentityManager)
(now for real)
Blocking: 883330
Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)
Owner: ma...@igalia.com
Status: Started (was: Available)
CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1333307
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e99023e1ae06723c65e6746d64ce3fa4a8b3befb

commit e99023e1ae06723c65e6746d64ce3fa4a8b3befb
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Tue Nov 13 16:37:11 2018

Migrate ChromeBrowserStateManagerImpl to the IdentityManager

Move away from SigninManagerBase::GetAuthenticatedAccountId() and
AccountTrackerService::GetAccountInfo(), to rely on the IdentityManager.

Bug:  903835 
Change-Id: Ia9b3f6251ad93b9cd6e042b54283b56fb0610bc8
Reviewed-on: https://chromium-review.googlesource.com/c/1333447
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607614}
[modify] https://crrev.com/e99023e1ae06723c65e6746d64ce3fa4a8b3befb/ios/chrome/browser/browser_state/BUILD.gn
[modify] https://crrev.com/e99023e1ae06723c65e6746d64ce3fa4a8b3befb/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment