New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 903827 link

Starred by 3 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Nov 12
Cc:
█ helenepark@chromium.org
markchang@chromium.org
bettes@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Tab loading animation] Make the determinate loading animation, animate progress

Project Member Reported by edwardjung@chromium.org, Nov 9 
From speaking to pbos@ the new progress indicator just jumps from one progress point to  the next rather than animating between positions.

For the fast loading sites, this isn't so much of an issue as the progress loads evenly.

However on pages with slow loading assets you see sometimes see the indicator leaps in segments and it can look janky.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98d67224c1af355a7578341060a591d2b6505578

commit 98d67224c1af355a7578341060a591d2b6505578
Author: Peter Boström <pbos@chromium.org>
Date: Mon Nov 12 20:19:16 2018

Interpolate loading progress in tab animation

Instead of skipping to the new load-progress value as it arrives,
interpolate to it. This results in a smoother animation as the
load-progress callbacks can be fairly sparse (and jump from 20% to 80%
for instance).

Drives animations off of the same timer that is used for the throbbing
state. This will hopefully address a performance regression as the
throbbing timer, progress fade-out animation and favicon fade-in
animation were all scheduling separate high-frequency repainting of the
tab icon.

Bug:  chromium:903827 ,  chromium:903147 , chromium:902475,  chromium:901751 

progress

Change-Id: Iad2a24d94206d5871a5cacc5e56d072161407940
Reviewed-on: https://chromium-review.googlesource.com/c/1330345
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607316}
[modify] https://crrev.com/98d67224c1af355a7578341060a591d2b6505578/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/98d67224c1af355a7578341060a591d2b6505578/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/98d67224c1af355a7578341060a591d2b6505578/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/98d67224c1af355a7578341060a591d2b6505578/chrome/browser/ui/views/tabs/tab_icon.cc
[modify] https://crrev.com/98d67224c1af355a7578341060a591d2b6505578/chrome/browser/ui/views/tabs/tab_icon.h
[modify] https://crrev.com/98d67224c1af355a7578341060a591d2b6505578/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/98d67224c1af355a7578341060a591d2b6505578/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/98d67224c1af355a7578341060a591d2b6505578/chrome/browser/ui/views/tabs/tab_unittest.cc

Comment 2 by pbos@chromium.org, Nov 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment