New issue
Advanced search Search tips

Issue 903818 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

U-Boot should support 1366 display width

Project Member Reported by sjg@chromium.org, Nov 9

Issue description

Careena has a display width of 1366 which is apparently not supported by the video uclass. It was supported with the old LCD system, so perhaps this support can be resurrected.
 
Same with TianoCore apparently.
Status: Started (was: Untriaged)
Patch sent. U-Boot was calculating the line length but needs to use what it is given from coreboot.

http://patchwork.ozlabs.org/patch/1005675/

Not sure about Tianocore but it probably has a similar problem.

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11

Labels: merge-merged-chromeos-v2018.09
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/u-boot/+/8084afd71b2989bbb1988488fcb1764202f79b2b

commit 8084afd71b2989bbb1988488fcb1764202f79b2b
Author: Simon Glass <sjg@chromium.org>
Date: Tue Dec 11 00:00:39 2018

UPSTREAM: video: Allow driver to specify the line length

At present line_length is always calculated in video_post_probe(). But
some hardware may use a different line length, e.g. with a 1366-wide
display.

Allow the driver to set this value if needed.

BUG= chromium:903818 
TEST=build and boot on careena; see that display is good now
Reviewed-by: Anatolij Gustschin <agust@denx.de>
Change-Id: I66e1cffc055e84d40c47ac1ed701127bcb4f57cc
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1366597
Reviewed-by: Raul E Rangel <rrangel@chromium.org>

[modify] https://crrev.com/8084afd71b2989bbb1988488fcb1764202f79b2b/drivers/video/video-uclass.c
[modify] https://crrev.com/8084afd71b2989bbb1988488fcb1764202f79b2b/drivers/pci/pci_rom.c
[modify] https://crrev.com/8084afd71b2989bbb1988488fcb1764202f79b2b/include/video.h

Status: Fixed (was: Started)
This is applied upstream. I am not going to venture into tianocore though.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 19

Labels: merge-merged-firmware-grunt-11031.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/u-boot/+/6b2672298d0d836879c0ba680575190867c1843b

commit 6b2672298d0d836879c0ba680575190867c1843b
Author: Simon Glass <sjg@chromium.org>
Date: Wed Dec 19 16:37:08 2018

UPSTREAM: video: Allow driver to specify the line length

At present line_length is always calculated in video_post_probe(). But
some hardware may use a different line length, e.g. with a 1366-wide
display.

Allow the driver to set this value if needed.

BUG= chromium:903818 
TEST=build and boot on careena; see that display is good now
Reviewed-by: Anatolij Gustschin <agust@denx.de>
Change-Id: I66e1cffc055e84d40c47ac1ed701127bcb4f57cc
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1366597
Reviewed-by: Raul E Rangel <rrangel@chromium.org>
(cherry picked from commit 8084afd71b2989bbb1988488fcb1764202f79b2b)
Reviewed-on: https://chromium-review.googlesource.com/c/1384584

[modify] https://crrev.com/6b2672298d0d836879c0ba680575190867c1843b/drivers/video/video-uclass.c
[modify] https://crrev.com/6b2672298d0d836879c0ba680575190867c1843b/drivers/pci/pci_rom.c
[modify] https://crrev.com/6b2672298d0d836879c0ba680575190867c1843b/include/video.h

Sign in to add a comment