New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903817 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Tab loading animation] Align the loading animation to the commit state

Project Member Reported by edwardjung@chromium.org, Nov 9

Issue description

Timeline for loading a page:
Navigation start  ---> Pending navigation (with possible redirects) ---> Commit ---> Loading ----> Done

Notes from creis@:
The backwards spinner seemed to happen for part of the "pending navigation" phase but it converts to a forwards spinner well before commit.

Proposal:
From Navigation start --> Commit, we should show the connecting animation, rather than jumping forward to the loading animation before commit.

The new loading animation is determinate so should be shown when loading starts rather than the possibility of looking stuck at 0%. 

The offset of this might be that it might feel slower initially, but the loading phase should progress accurately. We'll need to monitor when this lands and if this changes the perceive load speed.


 
Components: UI>Browser>Navigation
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9a27f6eb8b2daaa495f2f38499a8102c4b63e05

commit a9a27f6eb8b2daaa495f2f38499a8102c4b63e05
Author: Peter Boström <pbos@chromium.org>
Date: Wed Nov 21 13:12:19 2018

Align IsWaitingForResponse with NavigationRequest

This effectively aligns the tab-icon animation with page commits as the
navigation request only exists while the tab is navigating. This code is
also easier to understand since we don't need to keep track of when a
first response could have been received (and which navigation the
response is related to).

Bug:  chromium:903817 
Change-Id: I3629792f1a122a2445edc9a2cab02e38b0eeca7b
Reviewed-on: https://chromium-review.googlesource.com/c/1341992
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610023}
[modify] https://crrev.com/a9a27f6eb8b2daaa495f2f38499a8102c4b63e05/chrome/browser/ui/views/frame/browser_view_browsertest.cc
[modify] https://crrev.com/a9a27f6eb8b2daaa495f2f38499a8102c4b63e05/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/a9a27f6eb8b2daaa495f2f38499a8102c4b63e05/content/browser/web_contents/web_contents_impl.h

Status: Fixed (was: Assigned)

Sign in to add a comment