New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903815 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Make the TabGroup user study work out-of-box without forcing flags

Project Member Reported by wychen@google.com, Nov 9

Issue description

In the user study, it would be convenient if the users don't have to manually set the flags.

One solution is to use Finch, but Finch config doesn't differentiate Alpha channel users (yet?), so we have to use a fragile and error-prone way to specify the version range in the config file, with the possibility to negatively affect the real experiments underway if the config files are not updated correctly in coordination with the release schedule.

The alternative is to force the behavior downstream, and discard Finch settings locally. This approach is more localized, but it seems hard to NOT discard flags while discard Finch. It should be fine if these features cannot be overridden in chrome://flags, since that would break the UI for the targeted user study anyway.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9

Labels: merge-merged-mtm-exp
The following revision refers to this bug:
  https://chromium.googlesource.com/experimental/chromium/src/+/da9afe65fec93fc2238f61b43f71374c83483c23

commit da9afe65fec93fc2238f61b43f71374c83483c23
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Fri Nov 09 15:32:51 2018

Force flags for user study

For Tab Group/Strip to work correctly, the following Features are
forced:
- Horizontal Tab Switcher is force enabled
- Duet (split toolbar) is force disabled

This discards settings in Finch and flags.

Bug:  903815 
Change-Id: I3a2d121decb9096fe28f60d8c760158f81db458c
[modify] https://crrev.com/da9afe65fec93fc2238f61b43f71374c83483c23/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java

Labels: -merge-merged-mtm-exp
Status: Fixed (was: Started)
Woohoo! crbug integration is also there!

Sign in to add a comment