[Tab loading animation] Keep the favicon in place for same site navigations |
|||
Issue descriptionIn all cases where we show a favicon, this should only happen on commit. However for same site navigations the jumping from favicon > favicon placeholder > favicon causes unwanted attention in the tab strip. Propose when making same site navigations we should keep the current favicon and not show the placeholder square. - Assumption that in most cases the target page will have the same favicon. - The connecting and loading animations should be drawn over the favicon. - In cases where once we load the page requested the site changes the favicon we should just animate the favicon over the previous one. This could happen on say redirected pages.
,
Nov 9
Page reloads is an additional common case, where the favicon shouldn't be switched out to placeholder.
,
Nov 21
I'm not even sure we can do this one for M72, we'll need to investigate what same-site means and should probably go through privacy and security review. I'm bumping the revision and lowering prio on this one, I think our transition animations make this less critical. To be clear I agree with it, but I don't feel comfortable pushing this in without folks in the loop. +creis@ in case he has input, but it's not as urgent now.
,
Nov 21
It's also possible that users don't understand that we've started the connecting / loading process if there's no change to the favicon. edwardjung@ wdyt? Another exploration would be desaturating the favicon during the connecting state, that'd at leas show that your "ctrl+R" reacted.
,
Nov 21
I'm okay for this to be pushed back and acknowledge that we need to think about the security implications. Despite no change in icon, we would show the bouncing connecting state / determinate loader, so that would be the indicator something is happening. I'm hoping the fade in of the placeholder will help with the awkward flash of the favicon.
,
Dec 14
I'll reassign it to you since it's not ready for implementation unless we solve these issues. |
|||
►
Sign in to add a comment |
|||
Comment 1 by edwardjung@chromium.org
, Nov 9