New issue
Advanced search Search tips

Issue 903756 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Abrt in sk_abort_no_print

Project Member Reported by ClusterFuzz, Nov 9

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5072117420523520

Fuzzer: libFuzzer_gpu_raster_angle_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x0539000dd812
Crash State:
  sk_abort_no_print
  GrContextPriv::makeDeferredRenderTargetContextWithFallback
  GrContextPriv::makeDeferredRenderTargetContextWithFallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=606720:606721

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5072117420523520

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 9

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 9

Cc: piman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Nov 9

Labels: Test-Predator-Auto-Owner
Owner: egdaniel@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/51b1c12bbc2fa3f8d4faa29ad19c6f3cb34837ce (Have a GrBackendFormat be stored on gpu proxies.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/919c9e77c3492af766ff5982acda76ee49da3168

commit 919c9e77c3492af766ff5982acda76ee49da3168
Author: Greg Daniel <egdaniel@google.com>
Date: Fri Nov 09 15:33:23 2018

Revert "Have a GrBackendFormat be stored on gpu proxies."

This reverts commit 51b1c12bbc2fa3f8d4faa29ad19c6f3cb34837ce.

Reason for revert: reverting till flutter gets to 1.1 to fix build issues.

Original change's description:
> Have a GrBackendFormat be stored on gpu proxies.
>
> Bug: skia:
> Change-Id: Iaf1fb24ab29a61d44e5fa59a5e0867ed02dcda90
> Reviewed-on: https://skia-review.googlesource.com/c/168021
> Reviewed-by: Brian Osman <brianosman@google.com>
> Commit-Queue: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: I574fdc084ef5994596c51fb0d60423b5dc01b885
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:903701  chromium:903756 
Reviewed-on: https://skia-review.googlesource.com/c/169835
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>

[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/ccpr/GrCCAtlas.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/gl/GrGLGpu.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/ProxyTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/ops/GrLatticeOp.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrOnFlushResourceProvider.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/mtl/GrMtlTextureRenderTarget.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/effects/GrRRectBlurEffect.fp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/SkGpuDevice.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/vk/GrVkRenderTarget.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/gl/GrGLTexture.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrSurfaceProxy.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/ProxyConversionTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/vk/GrVkCaps.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrClipStackClip.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrAHardwareBufferImageGenerator.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrBlurUtils.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/gl/GrGLCaps.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrContextPriv.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/mock/GrMockTexture.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/include/gpu/GrSurface.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrDrawOpAtlas.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/text/GrTextContext.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrTextureRenderTargetProxy.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/SkGr.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/PrimitiveProcessorTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/gl/GrGLTextureRenderTarget.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/WritePixelsTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrTextureProxy.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/GrMeshTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/ccpr/GrCCClipPath.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrContext.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/PathRendererCacheTests.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/mtl/GrMtlRenderTarget.mm
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrCaps.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/include/private/GrRenderTargetProxy.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/vk/GrVkTexture.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/effects/imagefilters/SkXfermodeImageFilter.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/core/SkImageFilter.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/gl/GrGLTextureRenderTarget.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/mtl/GrMtlCaps.mm
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/gm/image_pict.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrYUVProvider.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/effects/imagefilters/SkAlphaThresholdFilter.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/vk/GrVkTextureRenderTarget.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrBackendSurface.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/OpChainTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/TextureProxyTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/DetermineDomainModeTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/TessellatingPathRendererTests.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/ops/GrTextureOp.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/gl/GrGLRenderTarget.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrOnFlushResourceProvider.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/vk/GrVkCaps.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/text/GrAtlasManager.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/RectangleTextureTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/DefaultPathRendererTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrRenderTargetProxy.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/ClearTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/vk/GrVkImage.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/effects/GrConfigConversionEffect.fp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/SRGBReadWritePixelsTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrTextureProducer.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/LazyProxyTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrRenderTargetContext.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/TraceMemoryDumpTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrTextureRenderTargetProxy.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/DrawOpAtlasTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/effects/imagefilters/SkDisplacementMapEffect.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrProxyProvider.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/mock/GrMockCaps.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/mtl/GrMtlTexture.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrYUVProvider.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/gl/GrGLRenderTarget.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrBackendTextureImageGenerator.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/gm/clockwise.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/GrCCPRTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/effects/GrRRectBlurEffect.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/ProxyRefTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrProxyProvider.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/mtl/GrMtlTexture.mm
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/include/private/GrSurfaceProxy.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/SpecialSurfaceTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/GLProgramsTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/samplecode/SampleCCPRGeometry.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/effects/GrConfigConversionEffect.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrCaps.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/bench/VertexColorSpaceBench.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/core/SkSpecialSurface.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrSoftwarePathRenderer.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/ProcessorTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/gm/windowrectangles.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/include/private/GrTextureProxy.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/OnFlushCallbackTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/mtl/GrMtlRenderTarget.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/ops/GrSmallPathRenderer.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/GrDrawOpAtlas.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/tests/ImageFilterTest.cpp
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/gl/GrGLTexture.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/gpu/mtl/GrMtlCaps.h
[modify] https://crrev.com/919c9e77c3492af766ff5982acda76ee49da3168/src/effects/imagefilters/SkLightingImageFilter.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97477fc11e6476b6fab50dccea7f69fdeb1309d4

commit 97477fc11e6476b6fab50dccea7f69fdeb1309d4
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Nov 09 18:00:01 2018

Roll src/third_party/skia c244c2fbbbf8..ef4709b7850d (8 commits)

https://skia.googlesource.com/skia.git/+log/c244c2fbbbf8..ef4709b7850d


git log c244c2fbbbf8..ef4709b7850d --date=short --no-merges --format='%ad %ae %s'
2018-11-09 mtklein@google.com move blend-row routines to SkBlitter_ARGB32.cpp
2018-11-09 mtklein@google.com get familiar with SkBlitMask_D32.cpp
2018-11-09 egdaniel@google.com Revert "Have a GrBackendFormat be stored on gpu proxies."
2018-11-09 mtklein@google.com remove unused typedef
2018-11-09 halcanary@google.com SkQP: script: fix non-existant build path
2018-11-09 reed@google.com remove guards for hinting in google3
2018-11-09 nathanrogers@google.com Fix another typo in SkSize comments
2018-11-09 nigeltao@google.com Merge SkFooAdapterCodec impls into one impl


Created with:
  gclient setdep -r src/third_party/skia@ef4709b7850d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:903701  chromium:903756 
TBR=allanmac@chromium.org

Change-Id: I49bf07d7c1d1b5a67bf3317b67cd93e5bcb44e6b
Reviewed-on: https://chromium-review.googlesource.com/c/1329504
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606895}
[modify] https://crrev.com/97477fc11e6476b6fab50dccea7f69fdeb1309d4/DEPS

Project Member

Comment 6 by ClusterFuzz, Nov 9

ClusterFuzz has detected this issue as fixed in range 606894:606902.

Detailed report: https://clusterfuzz.com/testcase?key=5072117420523520

Fuzzer: libFuzzer_gpu_raster_angle_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x0539000dd812
Crash State:
  sk_abort_no_print
  GrContextPriv::makeDeferredRenderTargetContextWithFallback
  GrContextPriv::makeDeferredRenderTargetContextWithFallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=606720:606721
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=606894:606902

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5072117420523520

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 9

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5072117420523520 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/2f9a5ea639925f38785f4d3a0af237822007cfd6

commit 2f9a5ea639925f38785f4d3a0af237822007cfd6
Author: Greg Daniel <egdaniel@google.com>
Date: Wed Nov 14 14:52:44 2018

Reland "Have a GrBackendFormat be stored on gpu proxies."

This reverts commit 919c9e77c3492af766ff5982acda76ee49da3168.

Reason for revert: Flutter change has landed and fixed memory issue.

Original change's description:
> Revert "Have a GrBackendFormat be stored on gpu proxies."
>
> This reverts commit 51b1c12bbc2fa3f8d4faa29ad19c6f3cb34837ce.
>
> Reason for revert: reverting till flutter gets to 1.1 to fix build issues.
>
> Original change's description:
> > Have a GrBackendFormat be stored on gpu proxies.
> >
> > Bug: skia:
> > Change-Id: Iaf1fb24ab29a61d44e5fa59a5e0867ed02dcda90
> > Reviewed-on: https://skia-review.googlesource.com/c/168021
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
>
> TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com
>
> Change-Id: I574fdc084ef5994596c51fb0d60423b5dc01b885
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:903701  chromium:903756 
> Reviewed-on: https://skia-review.googlesource.com/c/169835
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: Ifd9b6b8e194af9fb9258fa626644e76e6ecf090d
Bug: chromium:903701  chromium:903756 
Reviewed-on: https://skia-review.googlesource.com/c/170104
Commit-Queue: Greg Daniel <egdaniel@google.com>
Reviewed-by: Greg Daniel <egdaniel@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/ccpr/GrCCAtlas.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/gl/GrGLGpu.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/ProxyTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/ops/GrLatticeOp.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrOnFlushResourceProvider.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/mtl/GrMtlTextureRenderTarget.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/effects/GrRRectBlurEffect.fp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/SkGpuDevice.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/vk/GrVkRenderTarget.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/gl/GrGLTexture.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrSurfaceProxy.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/ProxyConversionTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/vk/GrVkCaps.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrClipStackClip.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrAHardwareBufferImageGenerator.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrBlurUtils.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/gl/GrGLCaps.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrContextPriv.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/mock/GrMockTexture.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/include/gpu/GrSurface.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrDrawOpAtlas.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/text/GrTextContext.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrTextureRenderTargetProxy.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/SkGr.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/PrimitiveProcessorTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/gl/GrGLTextureRenderTarget.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/WritePixelsTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrTextureProxy.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/GrMeshTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/ccpr/GrCCClipPath.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrContext.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/PathRendererCacheTests.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/mtl/GrMtlRenderTarget.mm
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrCaps.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/include/private/GrRenderTargetProxy.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/vk/GrVkTexture.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/effects/imagefilters/SkXfermodeImageFilter.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/core/SkImageFilter.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/gl/GrGLTextureRenderTarget.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/mtl/GrMtlCaps.mm
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/gm/image_pict.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrYUVProvider.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/effects/imagefilters/SkAlphaThresholdFilter.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/vk/GrVkTextureRenderTarget.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrBackendSurface.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/OpChainTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/TextureProxyTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/DetermineDomainModeTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/TessellatingPathRendererTests.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/ops/GrTextureOp.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/gl/GrGLRenderTarget.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrOnFlushResourceProvider.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/vk/GrVkCaps.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/text/GrAtlasManager.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/RectangleTextureTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/DefaultPathRendererTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrRenderTargetProxy.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/ClearTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/vk/GrVkImage.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/effects/GrConfigConversionEffect.fp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/SRGBReadWritePixelsTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrTextureProducer.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/LazyProxyTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrRenderTargetContext.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/TraceMemoryDumpTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrTextureRenderTargetProxy.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/DrawOpAtlasTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/effects/imagefilters/SkDisplacementMapEffect.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrProxyProvider.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/mock/GrMockCaps.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/mtl/GrMtlTexture.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrYUVProvider.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/gl/GrGLRenderTarget.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrBackendTextureImageGenerator.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/gm/clockwise.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/GrCCPRTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/effects/GrRRectBlurEffect.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/ProxyRefTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrProxyProvider.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/mtl/GrMtlTexture.mm
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/include/private/GrSurfaceProxy.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/SpecialSurfaceTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/GLProgramsTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/samplecode/SampleCCPRGeometry.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/effects/GrConfigConversionEffect.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrCaps.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/bench/VertexColorSpaceBench.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/core/SkSpecialSurface.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrSoftwarePathRenderer.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/ProcessorTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/gm/windowrectangles.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/include/private/GrTextureProxy.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/OnFlushCallbackTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/mtl/GrMtlRenderTarget.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/ops/GrSmallPathRenderer.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/GrDrawOpAtlas.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/tests/ImageFilterTest.cpp
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/gl/GrGLTexture.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/gpu/mtl/GrMtlCaps.h
[modify] https://crrev.com/2f9a5ea639925f38785f4d3a0af237822007cfd6/src/effects/imagefilters/SkLightingImageFilter.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2

commit d7157b2ccf53febde957a2c229e5f59fbd4f5cf2
Author: Greg Daniel <egdaniel@google.com>
Date: Wed Nov 14 15:28:15 2018

Revert "Reland "Have a GrBackendFormat be stored on gpu proxies.""

This reverts commit 2f9a5ea639925f38785f4d3a0af237822007cfd6.

Reason for revert: breaking fuchsia

Original change's description:
> Reland "Have a GrBackendFormat be stored on gpu proxies."
> 
> This reverts commit 919c9e77c3492af766ff5982acda76ee49da3168.
> 
> Reason for revert: Flutter change has landed and fixed memory issue.
> 
> Original change's description:
> > Revert "Have a GrBackendFormat be stored on gpu proxies."
> >
> > This reverts commit 51b1c12bbc2fa3f8d4faa29ad19c6f3cb34837ce.
> >
> > Reason for revert: reverting till flutter gets to 1.1 to fix build issues.
> >
> > Original change's description:
> > > Have a GrBackendFormat be stored on gpu proxies.
> > >
> > > Bug: skia:
> > > Change-Id: Iaf1fb24ab29a61d44e5fa59a5e0867ed02dcda90
> > > Reviewed-on: https://skia-review.googlesource.com/c/168021
> > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > Commit-Queue: Greg Daniel <egdaniel@google.com>
> >
> > TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com
> >
> > Change-Id: I574fdc084ef5994596c51fb0d60423b5dc01b885
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:903701  chromium:903756 
> > Reviewed-on: https://skia-review.googlesource.com/c/169835
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
> 
> TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com
> 
> Change-Id: Ifd9b6b8e194af9fb9258fa626644e76e6ecf090d
> Bug: chromium:903701  chromium:903756 
> Reviewed-on: https://skia-review.googlesource.com/c/170104
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com

Change-Id: Ia0556355e5775b2100901b7bfa37f97bb6ccd90f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:903701  chromium:903756 
Reviewed-on: https://skia-review.googlesource.com/c/171002
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/ccpr/GrCCAtlas.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/gl/GrGLGpu.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/ProxyTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/ops/GrLatticeOp.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrOnFlushResourceProvider.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/mtl/GrMtlTextureRenderTarget.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/effects/GrRRectBlurEffect.fp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/SkGpuDevice.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/vk/GrVkRenderTarget.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/gl/GrGLTexture.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrSurfaceProxy.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/ProxyConversionTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/vk/GrVkCaps.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrClipStackClip.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrAHardwareBufferImageGenerator.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrBlurUtils.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/gl/GrGLCaps.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrContextPriv.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/mock/GrMockTexture.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/include/gpu/GrSurface.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrDrawOpAtlas.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/text/GrTextContext.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrTextureRenderTargetProxy.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/SkGr.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/PrimitiveProcessorTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/gl/GrGLTextureRenderTarget.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/WritePixelsTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrTextureProxy.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/GrMeshTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/ccpr/GrCCClipPath.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrContext.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/PathRendererCacheTests.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/mtl/GrMtlRenderTarget.mm
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrCaps.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/include/private/GrRenderTargetProxy.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/vk/GrVkTexture.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/effects/imagefilters/SkXfermodeImageFilter.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/core/SkImageFilter.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/gl/GrGLTextureRenderTarget.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/mtl/GrMtlCaps.mm
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/gm/image_pict.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrYUVProvider.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/effects/imagefilters/SkAlphaThresholdFilter.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/vk/GrVkTextureRenderTarget.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrBackendSurface.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/OpChainTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/TextureProxyTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/DetermineDomainModeTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/TessellatingPathRendererTests.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/ops/GrTextureOp.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/gl/GrGLRenderTarget.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrOnFlushResourceProvider.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/vk/GrVkCaps.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/text/GrAtlasManager.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/RectangleTextureTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/DefaultPathRendererTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrRenderTargetProxy.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/ClearTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/vk/GrVkImage.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/effects/GrConfigConversionEffect.fp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/SRGBReadWritePixelsTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrTextureProducer.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/LazyProxyTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrRenderTargetContext.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/TraceMemoryDumpTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrTextureRenderTargetProxy.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/DrawOpAtlasTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/effects/imagefilters/SkDisplacementMapEffect.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrProxyProvider.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/mock/GrMockCaps.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/mtl/GrMtlTexture.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrYUVProvider.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/gl/GrGLRenderTarget.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrBackendTextureImageGenerator.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/gm/clockwise.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/GrCCPRTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/effects/GrRRectBlurEffect.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/ProxyRefTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrProxyProvider.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/mtl/GrMtlTexture.mm
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/include/private/GrSurfaceProxy.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/SpecialSurfaceTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/GLProgramsTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/samplecode/SampleCCPRGeometry.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/effects/GrConfigConversionEffect.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrCaps.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/bench/VertexColorSpaceBench.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/core/SkSpecialSurface.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrSoftwarePathRenderer.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/ProcessorTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/gm/windowrectangles.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/include/private/GrTextureProxy.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/OnFlushCallbackTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/mtl/GrMtlRenderTarget.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/ops/GrSmallPathRenderer.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/GrDrawOpAtlas.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/tests/ImageFilterTest.cpp
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/gl/GrGLTexture.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/gpu/mtl/GrMtlCaps.h
[modify] https://crrev.com/d7157b2ccf53febde957a2c229e5f59fbd4f5cf2/src/effects/imagefilters/SkLightingImageFilter.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6d25560bf9bc07b6ad1dda8f47e3e9a5f0bfcf4

commit f6d25560bf9bc07b6ad1dda8f47e3e9a5f0bfcf4
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Nov 14 18:15:17 2018

Roll src/third_party/skia 7f2b6fa66575..d7157b2ccf53 (3 commits)

https://skia.googlesource.com/skia.git/+log/7f2b6fa66575..d7157b2ccf53


git log 7f2b6fa66575..d7157b2ccf53 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 egdaniel@google.com Revert "Reland "Have a GrBackendFormat be stored on gpu proxies.""
2018-11-14 mtklein@google.com skip alpha scale if 256
2018-11-14 egdaniel@google.com Reland "Have a GrBackendFormat be stored on gpu proxies."


Created with:
  gclient setdep -r src/third_party/skia@d7157b2ccf53

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:903701  chromium:903756 ,chromium:903701  chromium:903756 
TBR=rmistry@chromium.org

Change-Id: Ib7f4f617164efa46fdc0435416971fbb06f2a197
Reviewed-on: https://chromium-review.googlesource.com/c/1335776
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608043}
[modify] https://crrev.com/f6d25560bf9bc07b6ad1dda8f47e3e9a5f0bfcf4/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/4065d45d2de171a36de60a0d7b094166bfa1a782

commit 4065d45d2de171a36de60a0d7b094166bfa1a782
Author: Greg Daniel <egdaniel@google.com>
Date: Mon Nov 19 18:51:07 2018

Reland "Reland "Have a GrBackendFormat be stored on gpu proxies.""

This is a reland of 2f9a5ea639925f38785f4d3a0af237822007cfd6

Original change's description:
> Reland "Have a GrBackendFormat be stored on gpu proxies."
> 
> This reverts commit 919c9e77c3492af766ff5982acda76ee49da3168.
> 
> Reason for revert: Flutter change has landed and fixed memory issue.
> 
> Original change's description:
> > Revert "Have a GrBackendFormat be stored on gpu proxies."
> >
> > This reverts commit 51b1c12bbc2fa3f8d4faa29ad19c6f3cb34837ce.
> >
> > Reason for revert: reverting till flutter gets to 1.1 to fix build issues.
> >
> > Original change's description:
> > > Have a GrBackendFormat be stored on gpu proxies.
> > >
> > > Bug: skia:
> > > Change-Id: Iaf1fb24ab29a61d44e5fa59a5e0867ed02dcda90
> > > Reviewed-on: https://skia-review.googlesource.com/c/168021
> > > Reviewed-by: Brian Osman <brianosman@google.com>
> > > Commit-Queue: Greg Daniel <egdaniel@google.com>
> >
> > TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com
> >
> > Change-Id: I574fdc084ef5994596c51fb0d60423b5dc01b885
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:903701  chromium:903756 
> > Reviewed-on: https://skia-review.googlesource.com/c/169835
> > Commit-Queue: Greg Daniel <egdaniel@google.com>
> > Reviewed-by: Greg Daniel <egdaniel@google.com>
> 
> TBR=egdaniel@google.com,bsalomon@google.com,brianosman@google.com
> 
> Change-Id: Ifd9b6b8e194af9fb9258fa626644e76e6ecf090d
> Bug: chromium:903701  chromium:903756 
> Reviewed-on: https://skia-review.googlesource.com/c/170104
> Commit-Queue: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Greg Daniel <egdaniel@google.com>
> Reviewed-by: Brian Osman <brianosman@google.com>

Bug: chromium:903701  chromium:903756 
Change-Id: Id1360067d8e928b0a4e1848dae8bc1e7f1994403
Reviewed-on: https://skia-review.googlesource.com/c/171660
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Greg Daniel <egdaniel@google.com>

[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/ccpr/GrCCAtlas.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/gl/GrGLGpu.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/ProxyTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/ops/GrLatticeOp.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrOnFlushResourceProvider.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/mtl/GrMtlTextureRenderTarget.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/effects/GrRRectBlurEffect.fp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/SkGpuDevice.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/vk/GrVkRenderTarget.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/gl/GrGLTexture.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrSurfaceProxy.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/ProxyConversionTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/vk/GrVkCaps.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrClipStackClip.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrAHardwareBufferImageGenerator.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrBlurUtils.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/gl/GrGLCaps.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/core/SkSpecialImage.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/GrPipelineDynamicStateTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrContextPriv.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/mock/GrMockTexture.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/include/gpu/GrSurface.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrDrawOpAtlas.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/ResourceCacheTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/text/GrTextContext.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrTextureRenderTargetProxy.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/SkGr.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/PrimitiveProcessorTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/gl/GrGLTextureRenderTarget.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/WritePixelsTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/image/SkSurface_Gpu.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrTextureProxy.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/GrMeshTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/ccpr/GrCCClipPath.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/ResourceAllocatorTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrContext.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/PathRendererCacheTests.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/image/SkImage_Gpu.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/mtl/GrMtlRenderTarget.mm
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/core/SkSpecialSurface.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrCaps.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/include/private/GrRenderTargetProxy.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/effects/imagefilters/SkArithmeticImageFilter.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/vk/GrVkTexture.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/effects/imagefilters/SkXfermodeImageFilter.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/core/SkImageFilter.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tools/gpu/ProxyUtils.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/gl/GrGLTextureRenderTarget.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/mtl/GrMtlCaps.mm
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/image/SkImage_Lazy.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/gm/image_pict.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrYUVProvider.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/effects/imagefilters/SkAlphaThresholdFilter.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/vk/GrVkTextureRenderTarget.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrBackendSurface.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/OpChainTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/TextureProxyTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/DetermineDomainModeTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/TessellatingPathRendererTests.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/ops/GrTextureOp.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/gl/GrGLRenderTarget.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrOnFlushResourceProvider.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/vk/GrVkCaps.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/text/GrAtlasManager.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/effects/imagefilters/SkMorphologyImageFilter.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/RectangleTextureTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/DefaultPathRendererTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrRenderTargetProxy.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/ClearTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/vk/GrVkImage.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/effects/GrConfigConversionEffect.fp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/core/SkGpuBlurUtils.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/SRGBReadWritePixelsTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/gl/GrGLCaps.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrTextureProducer.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/LazyProxyTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrRenderTargetContext.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/TraceMemoryDumpTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrTextureRenderTargetProxy.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/DrawOpAtlasTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/effects/imagefilters/SkDisplacementMapEffect.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrProxyProvider.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/mock/GrMockCaps.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/mtl/GrMtlTexture.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrYUVProvider.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/image/SkImage_GpuBase.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/gl/GrGLRenderTarget.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrBackendTextureImageGenerator.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/include/gpu/GrBackendSurface.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/gm/clockwise.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/GrCCPRTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/image/SkImage_GpuYUVA.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/effects/GrRRectBlurEffect.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/ProxyRefTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrProxyProvider.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/core/SkDeferredDisplayListRecorder.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/mtl/GrMtlTexture.mm
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/include/private/GrSurfaceProxy.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/SpecialSurfaceTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/GLProgramsTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/samplecode/SampleCCPRGeometry.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/effects/GrConfigConversionEffect.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrCaps.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/bench/VertexColorSpaceBench.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/core/SkSpecialSurface.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrSoftwarePathRenderer.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/ProcessorTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/GrSurfaceTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/gm/windowrectangles.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/include/private/GrTextureProxy.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/OnFlushCallbackTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/mtl/GrMtlRenderTarget.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/ops/GrSmallPathRenderer.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/GrDrawOpAtlas.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/tests/ImageFilterTest.cpp
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/gl/GrGLTexture.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/gpu/mtl/GrMtlCaps.h
[modify] https://crrev.com/4065d45d2de171a36de60a0d7b094166bfa1a782/src/effects/imagefilters/SkLightingImageFilter.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29aedda19a499368a0e4d06d232706df9dbd5726

commit 29aedda19a499368a0e4d06d232706df9dbd5726
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Nov 19 21:38:31 2018

Roll src/third_party/skia a1211832046d..4065d45d2de1 (9 commits)

https://skia.googlesource.com/skia.git/+log/a1211832046d..4065d45d2de1


git log a1211832046d..4065d45d2de1 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 egdaniel@google.com Reland "Reland "Have a GrBackendFormat be stored on gpu proxies.""
2018-11-19 halcanary@google.com Fuzz: un-inline some code
2018-11-19 halcanary@google.com SkPDF: move font serialization over to new immediate mode.
2018-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fde74c078f77..8a0fb48a56d6 (2 commits)
2018-11-19 brianosman@google.com Use half floats for non-normalized color in GrTextureOp
2018-11-19 mtklein@google.com simplify nextRange(), fold in nextEnum()
2018-11-19 scroggo@google.com Generate Android Framework host-side Skia (linux)
2018-11-19 brianosman@google.com Add helpers to deal with byte vs. half-float vertex colors
2018-11-19 jvanverth@google.com Revert "Reland "Remove use of integers for atlas indexing""


Created with:
  gclient setdep -r src/third_party/skia@4065d45d2de1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:903701  chromium:903756 ,chromium:b/118742766
TBR=csmartdalton@chromium.org

Change-Id: Ibf22c41fb40c189d24230a8df08d70e6809e2a90
Reviewed-on: https://chromium-review.googlesource.com/c/1342808
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609448}
[modify] https://crrev.com/29aedda19a499368a0e4d06d232706df9dbd5726/DEPS

Sign in to add a comment