API and implementation for network requests for the diagnostics_processor according to 10E doc.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/490f15c2ed79b13b997d642d8bc1c9fdeb924343 commit 490f15c2ed79b13b997d642d8bc1c9fdeb924343 Author: Polina Bondarenko <pbond@google.com> Date: Fri Dec 07 12:58:29 2018 diagnostics: implement PerformWebRequest gRPC method Wired up network requests for diagnostics_processor to browser. BUG=chromium:903745 TEST=unittests Change-Id: Ic48e0889e9bbc2614fa9cba3737a23680fbc3895 Reviewed-on: https://chromium-review.googlesource.com/c/1363570 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Tested-by: Polina Bondarenko <pbond@chromium.org> Trybot-Ready: Polina Bondarenko <pbond@chromium.org> [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/mojo/diagnosticsd.mojom [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/diagnosticsd_core.cc [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/fake_diagnostics_processor.cc [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/diagnosticsd_grpc_service.cc [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/diagnosticsd_grpc_service.h [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/diagnosticsd_mojo_service.h [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/diagnosticsd_mojo_service.cc [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/diagnosticsd_grpc_service_test.cc [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/mock_mojom_diagnosticsd_client.h [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/grpc/diagnosticsd.proto [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/diagnosticsd_mojo_service_test.cc [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/fake_diagnostics_processor.h [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/diagnosticsd_core.h [modify] https://crrev.com/490f15c2ed79b13b997d642d8bc1c9fdeb924343/diagnostics/diagnosticsd/diagnosticsd_core_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c91374cf04f7ad451e17bf608ecfce10a2a4469e commit c91374cf04f7ad451e17bf608ecfce10a2a4469e Author: Polina Bondarenko <pbond@google.com> Date: Thu Dec 13 14:50:43 2018 diagnostics: add response_body to PerformWebRequestResponse The web response body has to be passed back to diagnosticsd_processor on the PerformWebRequest call. BUG=chromium:903745 TEST=unittests Change-Id: I7190d8455abfbec100ca85ca4118ab2ec39ca444 Reviewed-on: https://chromium-review.googlesource.com/c/1371846 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Tested-by: Polina Bondarenko <pbond@chromium.org> Trybot-Ready: Polina Bondarenko <pbond@chromium.org> [modify] https://crrev.com/c91374cf04f7ad451e17bf608ecfce10a2a4469e/diagnostics/mojo/diagnosticsd.mojom [modify] https://crrev.com/c91374cf04f7ad451e17bf608ecfce10a2a4469e/diagnostics/diagnosticsd/diagnosticsd_core.cc [modify] https://crrev.com/c91374cf04f7ad451e17bf608ecfce10a2a4469e/diagnostics/diagnosticsd/diagnosticsd_grpc_service.cc [modify] https://crrev.com/c91374cf04f7ad451e17bf608ecfce10a2a4469e/diagnostics/diagnosticsd/diagnosticsd_grpc_service.h [modify] https://crrev.com/c91374cf04f7ad451e17bf608ecfce10a2a4469e/diagnostics/diagnosticsd/diagnosticsd_grpc_service_test.cc [modify] https://crrev.com/c91374cf04f7ad451e17bf608ecfce10a2a4469e/diagnostics/diagnosticsd/diagnosticsd_mojo_service.h [modify] https://crrev.com/c91374cf04f7ad451e17bf608ecfce10a2a4469e/diagnostics/diagnosticsd/mock_mojom_diagnosticsd_client.h [modify] https://crrev.com/c91374cf04f7ad451e17bf608ecfce10a2a4469e/diagnostics/grpc/diagnosticsd.proto [modify] https://crrev.com/c91374cf04f7ad451e17bf608ecfce10a2a4469e/diagnostics/diagnosticsd/diagnosticsd_mojo_service_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/536d5adf484b31192b1f0eb3f82078047d6462fe commit 536d5adf484b31192b1f0eb3f82078047d6462fe Author: Polina Bondarenko <pbond@chromium.org> Date: Thu Dec 13 15:36:58 2018 Revert "diagnostics: add response_body to PerformWebRequestResponse" This reverts commit c91374cf04f7ad451e17bf608ecfce10a2a4469e. Reason for revert: <INSERT REASONING HERE> Original change's description: > diagnostics: add response_body to PerformWebRequestResponse > > The web response body has to be passed back to diagnosticsd_processor on > the PerformWebRequest call. > > BUG=chromium:903745 > TEST=unittests > > Change-Id: I7190d8455abfbec100ca85ca4118ab2ec39ca444 > Reviewed-on: https://chromium-review.googlesource.com/c/1371846 > Reviewed-by: Roman Sorokin <rsorokin@chromium.org> > Commit-Queue: Polina Bondarenko <pbond@chromium.org> > Tested-by: Polina Bondarenko <pbond@chromium.org> > Trybot-Ready: Polina Bondarenko <pbond@chromium.org> Bug: chromium:903745 Change-Id: Icde97ffdb7db71c7c42f3f8ac12aea0ea81beeef Reviewed-on: https://chromium-review.googlesource.com/c/1375850 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Tested-by: Polina Bondarenko <pbond@chromium.org> Trybot-Ready: Polina Bondarenko <pbond@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/536d5adf484b31192b1f0eb3f82078047d6462fe/diagnostics/mojo/diagnosticsd.mojom [modify] https://crrev.com/536d5adf484b31192b1f0eb3f82078047d6462fe/diagnostics/diagnosticsd/diagnosticsd_core.cc [modify] https://crrev.com/536d5adf484b31192b1f0eb3f82078047d6462fe/diagnostics/diagnosticsd/diagnosticsd_grpc_service.cc [modify] https://crrev.com/536d5adf484b31192b1f0eb3f82078047d6462fe/diagnostics/diagnosticsd/diagnosticsd_grpc_service.h [modify] https://crrev.com/536d5adf484b31192b1f0eb3f82078047d6462fe/diagnostics/diagnosticsd/diagnosticsd_grpc_service_test.cc [modify] https://crrev.com/536d5adf484b31192b1f0eb3f82078047d6462fe/diagnostics/diagnosticsd/diagnosticsd_mojo_service.h [modify] https://crrev.com/536d5adf484b31192b1f0eb3f82078047d6462fe/diagnostics/diagnosticsd/mock_mojom_diagnosticsd_client.h [modify] https://crrev.com/536d5adf484b31192b1f0eb3f82078047d6462fe/diagnostics/grpc/diagnosticsd.proto [modify] https://crrev.com/536d5adf484b31192b1f0eb3f82078047d6462fe/diagnostics/diagnosticsd/diagnosticsd_mojo_service_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af commit bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af Author: Polina Bondarenko <pbond@google.com> Date: Tue Dec 18 08:42:58 2018 Reland "diagnostics: add response_body to PerformWebRequestResponse" This is a reland of c91374cf04f7ad451e17bf608ecfce10a2a4469e Reason for reland: this commit has been reverted because it was merged directly without a CQ. Relanding it to merge properly. Original change's description: > diagnostics: add response_body to PerformWebRequestResponse > > The web response body has to be passed back to diagnosticsd_processor on > the PerformWebRequest call. > > BUG=chromium:903745 > TEST=unittests > > Change-Id: I7190d8455abfbec100ca85ca4118ab2ec39ca444 > Reviewed-on: https://chromium-review.googlesource.com/c/1371846 > Reviewed-by: Roman Sorokin <rsorokin@chromium.org> > Commit-Queue: Polina Bondarenko <pbond@chromium.org> > Tested-by: Polina Bondarenko <pbond@chromium.org> > Trybot-Ready: Polina Bondarenko <pbond@chromium.org> Bug: chromium:903745 Change-Id: I63ae571e1932598ea034de4ce408a30637f47739 Reviewed-on: https://chromium-review.googlesource.com/1375851 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Polina Bondarenko <pbond@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> [modify] https://crrev.com/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af/diagnostics/mojo/diagnosticsd.mojom [modify] https://crrev.com/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af/diagnostics/diagnosticsd/diagnosticsd_core.cc [modify] https://crrev.com/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af/diagnostics/diagnosticsd/diagnosticsd_grpc_service.cc [modify] https://crrev.com/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af/diagnostics/diagnosticsd/diagnosticsd_grpc_service.h [modify] https://crrev.com/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af/diagnostics/diagnosticsd/diagnosticsd_grpc_service_test.cc [modify] https://crrev.com/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af/diagnostics/diagnosticsd/diagnosticsd_mojo_service.h [modify] https://crrev.com/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af/diagnostics/diagnosticsd/mock_mojom_diagnosticsd_client.h [modify] https://crrev.com/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af/diagnostics/grpc/diagnosticsd.proto [modify] https://crrev.com/bf438d6a3c4d18a5aeb963a86f48d7ec44fbe4af/diagnostics/diagnosticsd/diagnosticsd_mojo_service_test.cc
Note to self: update gRPC, mojom interfaces/descriptions according to the browser's part.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb2709d14ec7935c0ee32f287c8b052708b64a95 commit fb2709d14ec7935c0ee32f287c8b052708b64a95 Author: Polina Bondarenko <pbond@google.com> Date: Mon Jan 21 20:57:10 2019 diagnostics: Add PerformWebRequest method to mojom Add implementation of PerformWebRequest method in DiagnosticsdBridge that performs the web requests initiated by diagnosticsd daemon. Add unit tests for new DiagnosticsdWebRequestService. BUG=chromium:903745 TEST=unit_tests Change-Id: I528f7c850067146ff3b7b473179a69e83f2d3253 Reviewed-on: https://chromium-review.googlesource.com/c/1386868 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#624655} [modify] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/chrome_browser_main_chromeos.cc [modify] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/diagnosticsd/diagnosticsd_bridge.cc [modify] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/diagnosticsd/diagnosticsd_bridge.h [modify] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/diagnosticsd/diagnosticsd_bridge_unittest.cc [add] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/diagnosticsd/diagnosticsd_web_request_service.cc [add] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/diagnosticsd/diagnosticsd_web_request_service.h [add] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/diagnosticsd/diagnosticsd_web_request_service_unittest.cc [add] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/diagnosticsd/mojo_utils.cc [add] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/browser/chromeos/diagnosticsd/mojo_utils.h [modify] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/services/diagnosticsd/public/mojom/BUILD.gn [modify] https://crrev.com/fb2709d14ec7935c0ee32f287c8b052708b64a95/chrome/services/diagnosticsd/public/mojom/diagnosticsd.mojom
Comment 1 by lamzin@google.com
, Nov 13