New issue
Advanced search Search tips

Issue 903732 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Flaky-Test: http/tests/preload/delaying_onload_link_preload_after_discovery.html



Sign in to add a comment

http/tests/preload/delaying_onload_link_preload_after_discovery.html is flaky

Project Member Reported by Findit, Nov 9

Issue description


Flaky test: http/tests/preload/delaying_onload_link_preload_after_discovery.html
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests%20%28dbg%29/6321
Test output log: https://chromium-swarm.appspot.com/task?id=4110433792355510
Culprit (70.0% confidence): r606448
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKsAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS82MzIxL3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvYUhSMGNDOTBaWE4wY3k5d2NtVnNiMkZrTDJSbGJHRjVhVzVuWDI5dWJHOWhaRjlzYVc1clgzQnlaV3h2WVdSZllXWjBaWEpmWkdselkyOTJaWEo1TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20http/tests/preload/delaying_onload_link_preload_after_discovery.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKsAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS82MzIxL3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvYUhSMGNDOTBaWE4wY3k5d2NtVnNiMkZrTDJSbGJHRjVhVzVuWDI5dWJHOWhaRjlzYVc1clgzQnlaV3h2WVdSZllXWjBaWEpmWkdselkyOTJaWEo1TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Labels: OS-iOS
Reverting culprit
Labels: -Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43673375d85dfc8257c262cab39b6d62d7a81cfe

commit 43673375d85dfc8257c262cab39b6d62d7a81cfe
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Nov 09 12:20:57 2018

Revert "Reland^4 "[blink] Control ScriptStreamer with ScriptResource""

This reverts commit aaeff5e6358a4b69fe1c92d30ffa04a703690879.

Reason for revert: Findit thinks this CL makes delaying_onload_link_preload_after_discovery.html flaky with 70% confidence. Let's give it a shot and see if this fixes the flaking. Sorry, and let's hope the 5th reland goes better!

Original change's description:
> Reland^4 "[blink] Control ScriptStreamer with ScriptResource"
> 
> This is a reland of 31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11
> which was a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4,
> which was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7,
> which was a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
> 
> Relanding with no changes, seems that this wasn't the cause of
> https://crbug.com/902832 after all.
> 
> Original change's description:
> > Reland^3 "[blink] Control ScriptStreamer with ScriptResource"
> >
> > This is a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4, which
> > was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7, which was
> > a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
> >
> > VR tests have been properly deflaked in https://crrev.com/c/1319715, this
> > is otherwise unchanged.
> >
> > Original change's description:
> > > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > >
> > > This reverts commit c564235ff692fe0b3d926152748feb7902e8a800.
> > >
> > > No changes from the original, VR flakes are caused by issues with
> > > loadUrl and have been deflaked (see 894796 for details)
> > >
> > > Original change's description:
> > > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > > >
> > > > This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.
> > > >
> > > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> > > >
> > > > Original change's description:
> > > > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > > > >
> > > > > This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
> > > > >
> > > > > No changes from the original, revert reason is fixed with
> > > > > https://chromium-review.googlesource.com/c/1283037
> > > > >
> > > > > Original change's description:
> > > > > > [blink] Control ScriptStreamer with ScriptResource
> > > > > >
> > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > > > ScriptResource. In the future, this will allow us to start streaming
> > > > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > > > preload.
> > > > > >
> > > > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > > > ScriptResource. This callback is either when the streaming completes,
> > > > > > or when there is no streaming and the ClassicPendingScript has told
> > > > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > > > long run, we want all scripts to go through the streaming interface,
> > > > > > and we want ScriptResource to control when streaming starts, so the
> > > > > > "no more streaming" call will disappear -- however it is necessary to
> > > > > > maintain the current behaviour, and be able to control it with a
> > > > > > runtime flag.
> > > > > >
> > > > > > Bug: chromium:865098
> > > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > > > >
> > > > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > > > >
> > > > > Bug: chromium:865098
> > > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#601143}
> > > >
> > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#602310}
> > >
> > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:865098
> > > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#605295}
> >
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
> >
> > Bug: chromium:865098
> > Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
> > Reviewed-on: https://chromium-review.googlesource.com/c/1318923
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#605815}
> 
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
> 
> Bug: chromium:865098
> Change-Id: I73854c4d524ab0cc8e08ef512c10334f0ab5ead4
> Reviewed-on: https://chromium-review.googlesource.com/c/1325921
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606448}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: I6d2bbe9085376921d819c015bf37832efe8d2d11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098,  chromium:903732 
Reviewed-on: https://chromium-review.googlesource.com/c/1328966
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606804}
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/bindings/core/v8/script_streamer.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/bindings/core/v8/script_streamer.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/loader/resource/script_resource.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/script/classic_pending_script.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/script/document_write_intervention.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/43673375d85dfc8257c262cab39b6d62d7a81cfe/tools/metrics/histograms/enums.xml

Owner: leszeks@chromium.org
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)
Presumably the flakiness is fixed.

Sign in to add a comment