clank bisect: 'RunResult' object has no attribute 'decode' |
||||
Issue description
I am not sure of the current status of Clank bisects. Feel free to close as wontfix if the error is expected.
I've just encountered this:
Traceback (most recent call last):
File "/b/build/slave/clankium-phone-perf-bisect/build/catapult/tracing/bin/compare_samples", line 51, in <module>
sys.exit(Main(sys.argv))
File "/b/build/slave/clankium-phone-perf-bisect/build/catapult/tracing/bin/compare_samples", line 46, in Main
stdout = stdout.decode('utf-8')
AttributeError: 'RunResult' object has no attribute 'decode'
step returned non-zero exit code: 1
Here:
https://logs.chromium.org/logs/chrome/bb/internal.tryserver.clankium/clankium-phone-perf-bisect/1052/+/recipes/steps/Compare_samples/0/stdout
,
Nov 10
Yes, that's a bad change, sorry. https://chromium-review.googlesource.com/c/catapult/+/1304593/8/tracing/bin/compare_samples should be `stdout = vinn_result.stdout` Feel free to make a change with this fix, or restore this file to its previous state, or even revert the whole CL, though that's a bit drastic. Because I may be quite delayed in sending out the change myself.
,
Nov 12
oprypin: thanks for suggestions, in flight: https://chromium-review.googlesource.com/c/catapult/+/1331427
,
Nov 12
dtu: thanks for quick triage! Appreciated!
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/d1eeca86af6e45a61f88964e085ed4745c8570ec commit d1eeca86af6e45a61f88964e085ed4745c8570ec Author: Egor Pasko <pasko@chromium.org> Date: Mon Nov 12 12:38:05 2018 compare_samples: trivial fix in Main This issue is currently blocking perf bisects for Chrome on Android. Bug: chromium:903730 Change-Id: I0474eb563741dde7e77c49601c105eb8b8890bd1 TBR=nednguyen@google.com,oprypin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1331427 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> [modify] https://crrev.com/d1eeca86af6e45a61f88964e085ed4745c8570ec/tracing/bin/compare_samples
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1aaf0d36b2b4d3eed4a06364d4542cb1ef83d573 commit 1aaf0d36b2b4d3eed4a06364d4542cb1ef83d573 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Nov 12 14:11:21 2018 Roll src/third_party/catapult 662c038f3fdd..d1eeca86af6e (1 commits) https://chromium.googlesource.com/catapult.git/+log/662c038f3fdd..d1eeca86af6e git log 662c038f3fdd..d1eeca86af6e --date=short --no-merges --format='%ad %ae %s' 2018-11-12 pasko@chromium.org compare_samples: trivial fix in Main Created with: gclient setdep -r src/third_party/catapult@d1eeca86af6e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:903730 TBR=sullivan@chromium.org Change-Id: I4d634429ea4da913126e51853cedacfe48ab37b4 Reviewed-on: https://chromium-review.googlesource.com/c/1331409 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607216} [modify] https://crrev.com/1aaf0d36b2b4d3eed4a06364d4542cb1ef83d573/DEPS
,
Nov 13
,
Nov 13
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dtu@google.com
, Nov 10Components: -Speed>Bisection Speed>Tracing
Owner: oprypin@chromium.org