New issue
Advanced search Search tips

Issue 903723 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::FlatTreeTraversal::TraverseChild

Project Member Reported by ClusterFuzz, Nov 9

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5111821977255936

Fuzzer: bj_broddelwerk
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::FlatTreeTraversal::TraverseChild
  blink::FlatTreeTraversal::LastWithinOrSelf
  blink::PositionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> >::Nod
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=606747:606748

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5111821977255936

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 9

Labels: OS-Mac
Project Member

Comment 2 by ClusterFuzz, Nov 9

Components: Blink>DOM
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Nov 9

Labels: Test-Predator-Auto-Owner
Owner: xiaoche...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/4d281c8de3c433b6660a63af2b33977800d94aca (Make InlineContents traverse flat tree for previous and next).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: -Blink>DOM Blink>Editing
Cc: xiaoche...@chromium.org
 Issue 903733  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1810df1362cda0d3a9a2844fdb43ee0d95adb191

commit 1810df1362cda0d3a9a2844fdb43ee0d95adb191
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Nov 13 05:18:24 2018

Stop InlineContents iteration when reaching document boundary

This patch stops a crash in InlineContents previous/next iteration by
terminating the iteration at document boundary, so that subsequent
operations don't proceed with invalid parameters.

Bug:  903723 
Change-Id: Iaed2ac1d5d74d3ab59da3a2f0db2d4f8150fb21b
Reviewed-on: https://chromium-review.googlesource.com/c/1331571
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607499}
[modify] https://crrev.com/1810df1362cda0d3a9a2844fdb43ee0d95adb191/third_party/blink/renderer/core/editing/text_offset_mapping.cc
[modify] https://crrev.com/1810df1362cda0d3a9a2844fdb43ee0d95adb191/third_party/blink/renderer/core/editing/text_offset_mapping_test.cc

Project Member

Comment 7 by ClusterFuzz, Nov 13

ClusterFuzz has detected this issue as fixed in range 607498:607499.

Detailed report: https://clusterfuzz.com/testcase?key=5111821977255936

Fuzzer: bj_broddelwerk
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::FlatTreeTraversal::TraverseChild
  blink::FlatTreeTraversal::LastWithinOrSelf
  blink::PositionTemplate<blink::EditingAlgorithm<blink::FlatTreeTraversal> >::Nod
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=606747:606748
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=607498:607499

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5111821977255936

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Nov 13

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5111821977255936 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment