Convert ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm to IdentityManager |
||
Issue descriptionAPI used: - SetAuthenticatedAccountInfo()
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7586428da170b5323c25305dd3e213c38c6aa41 commit c7586428da170b5323c25305dd3e213c38c6aa41 Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Nov 09 17:58:16 2018 Migrate clear_browsing_data_collection_view_controller_unittest.mm to IdentityManager Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually creating the browser's state by providing specific factories, and then use the APIs from IdentityTestEnvironment, instead of SigninManagerBase. Also remove an unnecessary DCHECK in clear_browsing_data_manager_unittest.mm, as pointed out post-review when fixing crbug.com/890826 (CL 1318974). Bug: 903703 Change-Id: I9d4dd625441005a36c962628fe3fe1f15ab56bb6 Reviewed-on: https://chromium-review.googlesource.com/c/1328985 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#606894} [modify] https://crrev.com/c7586428da170b5323c25305dd3e213c38c6aa41/ios/chrome/browser/ui/settings/BUILD.gn [modify] https://crrev.com/c7586428da170b5323c25305dd3e213c38c6aa41/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm [modify] https://crrev.com/c7586428da170b5323c25305dd3e213c38c6aa41/ios/chrome/browser/ui/settings/clear_browsing_data_manager_unittest.mm
,
Nov 9
|
||
►
Sign in to add a comment |
||
Comment 1 by ma...@igalia.com
, Nov 9