Spanner margins disappear after certain multicol container style changes |
|||
Issue descriptionWPT import https://crrev.com/c/1328706 introduced new failures in external/wpt/css/css-multicol: List of new failures: external/wpt/css/css-multicol/multicol-span-all-restyle-003.html [ Failure ] This import contains upstream changes from d5be80a86d4f938250c075ac12414ad47516969c to a996d2028df7fe48935f1e8303cbd49dfb6a59d7: Part 5 - Fix anonymous -moz-column-span-wrapper block's style is overridden after restyling.: https://github.com/web-platform-tests/wpt/commit/a996d2028df7fe48935f1e8303cbd49dfb6a59d7 [affecting this directory] Part 3 - Support dynamically adding or removing elements under multi-column subtree.: https://github.com/web-platform-tests/wpt/commit/e2d7a959af7bfdf573edc0ea50bc47e8137444b6 [affecting this directory] html: Fix a sanitization issue of type-change-state.html: https://github.com/web-platform-tests/wpt/commit/3cd60908e05beed166359907018c2abe238cb205
,
Nov 9
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c95b6ff66bfb1807917bcc1aab4a36c84051901a commit c95b6ff66bfb1807917bcc1aab4a36c84051901a Author: Morten Stenshorne <mstensho@chromium.org> Date: Mon Nov 12 09:52:34 2018 Opt out of anonymous style propagation for spanner placeholders. LayoutObject::PropagateStyleToAnonymousChildren() doesn't do the right thing for LayoutMultiColumnSpannerPlaceholder. Spanner placeholders need to copy the margins from the actual spanner object, in addition to inheriting properties from the parent of the actual spanner. Bug: 903699 Change-Id: I4252c546610eca2698efd523f98f20a98627d217 Reviewed-on: https://chromium-review.googlesource.com/c/1328986 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#607179} [modify] https://crrev.com/c95b6ff66bfb1807917bcc1aab4a36c84051901a/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/c95b6ff66bfb1807917bcc1aab4a36c84051901a/third_party/blink/renderer/core/layout/layout_multi_column_spanner_placeholder.cc [modify] https://crrev.com/c95b6ff66bfb1807917bcc1aab4a36c84051901a/third_party/blink/renderer/core/layout/layout_multi_column_spanner_placeholder.h
,
Nov 12
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mstensho@chromium.org
, Nov 9Status: Available (was: Untriaged)
Summary: Spanner margins disappear after certain multicol container style changes (was: [WPT] New failures introduced in external/wpt/css/css-multicol by import https://crrev.com/c/1328706)