New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903696 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
OOO Dec 22 - Jan 8
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: AudioOutputDeviceTest.VerifyDataFlow


Participants' hotlists:
AudioService-FixIt
Audio-Service


Sign in to add a comment

AudioOutputDeviceTest.VerifyDataFlow is flaky

Project Member Reported by Findit, Nov 9

Issue description

Labels: -Sheriff-Chromium
Owner: olka@chromium.org
Status: Assigned (was: Untriaged)
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=903747 for the, I believe, incorrect culprit suggested by findit.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b39a541429c5031a7a7d12d13ade6fd69a10356

commit 3b39a541429c5031a7a7d12d13ade6fd69a10356
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Nov 09 12:39:32 2018

Revert "Don't make a LayerTreeFrameSink for a non-visible RenderWidget."

This reverts commit 68d8dbc019fd37659252e273ade868aac7a9d8ac.

Reason for revert: Looks like it makes PrerenderBrowserTest.PrerenderInfiniteLoop according to FindIt. 

../../chrome/browser/prerender/prerender_browsertest.cc:1721: Failure
Expected equality of these values:
  1U
    Which is: 1
  GetLinkPrerenderCount()
    Which is: 2

Original change's description:
> Don't make a LayerTreeFrameSink for a non-visible RenderWidget.
> 
> Importantly, non-visible RenderWidgets include swapped out RenderWidgets
> which are zombies, without a frame, and which should not be used.
> 
> This can happen if the RenderWidget swap out races with the posted task
> from the compositor to make a LayerTreeFrameSink. When swapping out, the
> compositor would be marked as not-visible, which would stop it from
> making such requests, but one could already be in flight.
> 
> In the other case, honoring the request for a non-visible compositor is
> more benign, but we can delay it until the compositor is actually
> visible again. This means if a context is lost, backgrounded tabs would
> not all attempt to reconnect to the Gpu process at once.
> 
> This is a better followup for the hacky
> https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which
> was meant only for merge to a release branch. It reverts that change as
> part of this one.
> 
> R=​piman@chromium.org
> 
> Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7
> Bug: 896836, 419087
> Reviewed-on: https://chromium-review.googlesource.com/c/1292714
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606655}

TBR=danakj@chromium.org,dcheng@chromium.org,piman@chromium.org

Change-Id: I65238aba0abdb6c9192e9f3cb3691f8dd89b3ea5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896836, 419087, 903696
Reviewed-on: https://chromium-review.googlesource.com/c/1329003
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606807}
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/renderer/gpu/layer_tree_view.cc
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/renderer/gpu/layer_tree_view_delegate.h
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/renderer/input/widget_input_handler_impl.cc
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/renderer/input/widget_input_handler_manager.cc
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/renderer/render_view_impl.cc
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/renderer/render_widget.cc
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/renderer/render_widget.h
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/test/stub_layer_tree_view_delegate.cc
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/content/test/stub_layer_tree_view_delegate.h
[modify] https://crrev.com/3b39a541429c5031a7a7d12d13ade6fd69a10356/third_party/blink/renderer/core/exported/web_view_impl.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4dc1efff9f39f75768c64004fea6a83b7b38d71

commit a4dc1efff9f39f75768c64004fea6a83b7b38d71
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Nov 09 13:01:58 2018

Disable AudioOutputDeviceTest.VerifyDataFlow.

Flakily fails like this:
../../media/audio/audio_output_device_unittest.cc:411: Failure
Actual function call count doesn't match EXPECT_CALL(env.callback,
    Render(kDelay, env.time_stamp, kFramesSkipped, NotNull()))...
         Expected: to be called once
           Actual: never called - unsatisfied and active

See for instance
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/
    Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30025

Tbr: olka@chromium.org
Bug: 903696
Change-Id: I621eab844322e47a36cfa55ddf6c09c04d825266
Reviewed-on: https://chromium-review.googlesource.com/c/1328987
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606811}
[modify] https://crrev.com/a4dc1efff9f39f75768c64004fea6a83b7b38d71/media/audio/audio_output_device_unittest.cc

Sign in to add a comment