New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903692 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Send workarea insets to arc in pixels

Project Member Reported by osh...@chromium.org, Nov 9

Issue description

Since display is now sent in pixels, work area should also be sent in pixels.
 
Summary: Send workarea insets to arc in pixels (was: Send workare insets to arc in pixels)
Cc: alexlau@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fcec02f63b1894c51157c3a69a799a137338e84

commit 3fcec02f63b1894c51157c3a69a799a137338e84
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Jan 14 20:17:25 2019

Workspace protocol update:

* Sends insets in client's pixel size.
* Explicitly sends stable insets (unaffected by shelf state)
  This will fix the issue where the stable insets is incorrect when
  the shelf side has changed during auto hide.
* Unify display /workspace into one WorkspaceInfo.
 Removed unnecessary "scale_factor".
* Added systemui_visibility to nofity the state of shelf.
  This is necessary to compute correct contentInsets when the shelf
  is set to autohide by a user.

Android side change:
https://googleplex-android-review.git.corp.google.com/q/topic:%2522stable-insets%2522

Bug: 903692, b/119841340
Test: updated tests to verify stable insets. Manually testsed on device.
Change-Id: I6fa6673c59d6d5f4db8eddbf75c184296e182029
Reviewed-on: https://chromium-review.googlesource.com/c/1401405
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Dominik Laskowski <domlaskowski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622573}
[modify] https://crrev.com/3fcec02f63b1894c51157c3a69a799a137338e84/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/3fcec02f63b1894c51157c3a69a799a137338e84/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/3fcec02f63b1894c51157c3a69a799a137338e84/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/3fcec02f63b1894c51157c3a69a799a137338e84/components/exo/wayland/server_util.cc
[modify] https://crrev.com/3fcec02f63b1894c51157c3a69a799a137338e84/components/exo/wayland/server_util.h
[modify] https://crrev.com/3fcec02f63b1894c51157c3a69a799a137338e84/components/exo/wayland/zcr_remote_shell.cc
[modify] https://crrev.com/3fcec02f63b1894c51157c3a69a799a137338e84/components/exo/wayland/zcr_remote_shell.h
[modify] https://crrev.com/3fcec02f63b1894c51157c3a69a799a137338e84/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml

Sign in to add a comment