New issue
Advanced search Search tips

Issue 903674 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Roll to Xcode 10.1 to remove letterboxed iPad Pros

Project Member Reported by justincohen@chromium.org, Nov 9

Issue description

Roll to 10B61.
 
Labels: M-71
Labels: OS-iOS
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/520c4ad0664f0523cf3f0da993d6f2058867ae20

commit 520c4ad0664f0523cf3f0da993d6f2058867ae20
Author: Justin Cohen <justincohen@google.com>
Date: Fri Nov 09 19:17:45 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16848611e68415411da26f8aa2547d5344ad174b

commit 16848611e68415411da26f8aa2547d5344ad174b
Author: Justin Cohen <justincohen@google.com>
Date: Fri Nov 09 21:50:55 2018

[ios] Roll to Xcode 10.1.

CIPD packages:
  infra_internal/ios/xcode/mac  10b61
  infra_internal/ios/xcode/ios  10b61

Bug:  903674 
Change-Id: Ifd61e84840a4ff9d36a215ad0c8d11efc51cbfd0
Reviewed-on: https://chromium-review.googlesource.com/c/1329022
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606983}
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.clang/ToTiOS.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.clang/ToTiOSDevice.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.fyi/ios-device-goma-canary-clobber.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.fyi/ios-simulator-cronet.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.fyi/ios-simulator.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.fyi/ios-slimnav.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.fyi/ios12-beta-simulator.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.mac/ios-device-xcode-clang.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.mac/ios-device.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.mac/ios-simulator-cronet.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.mac/ios-simulator-full-configs.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.mac/ios-simulator-xcode-clang.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.mac/ios-simulator.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.mac/ios-uirefresh-simulator.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.mac/ios-webview.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.mac/ios12-sdk-simulator.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.webrtc.fyi/WebRTC Chromium FYI ios-device.json
[modify] https://crrev.com/16848611e68415411da26f8aa2547d5344ad174b/ios/build/bots/chromium.webrtc.fyi/WebRTC Chromium FYI ios-simulator.json

Labels: Merge-Request-71
Status: Fixed (was: Assigned)
Already verified on ios-canary, bots are green
Needed to remove letterboxing for new ipad pros
Not behind a flag
Generally dot releases are low risk.
Cc: kariahda@chromium.org
Status: Verified (was: Fixed)
kariahda@: I'd like to get this on 71 as soon as possible.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 10

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: Less than 20 days to go before AppStore submit on M71
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0892fae390e000b9b9e9693450f02db1788c9cf0

commit 0892fae390e000b9b9e9693450f02db1788c9cf0
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Nov 12 19:48:38 2018

luci: update xcode cache version.

Tbr: justincohen@chromium.org
Bug:  903674 
No-Try: true
Change-Id: Icc14807608fbd7eac94a129a6c0a6b41b187d34d
Reviewed-on: https://chromium-review.googlesource.com/c/1331828
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607308}
[modify] https://crrev.com/0892fae390e000b9b9e9693450f02db1788c9cf0/infra/config/global/cr-buildbucket.cfg

Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Merge approved to 71, branch 3578.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 13

Labels: -merge-approved-71 Merge-Merged-3578
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/f36eb7506543479f62b0c5be101b9b14c5ca884b

commit f36eb7506543479f62b0c5be101b9b14c5ca884b
Author: Justin Cohen <justincohen@google.com>
Date: Tue Nov 13 15:11:13 2018

Labels: HIG_Feedback

Sign in to add a comment