ArcWindowDelegateImpl::IsInArcAppWindow crashes at login |
|||||
Issue descriptionAccording to Xiyuan's comment in crrev.com/c/1291289 exo::WMHelper::GetInstance() can be null in ArcWindowDelegateImpl::IsInArcAppWindow. (gdb) bt #0 0x00005ea11f0a5ba6 in arc::(anonymous namespace)::ArcWindowDelegateImpl::IsInArcAppWindow(aura::Window const*) const () at ../../components/arc/ime/arc_ime_service.cc:56 #1 0x00005ea11f0a4172 in arc::ArcImeService::OnWindowFocused(aura::Window*, aura::Window*) () at ../../components/arc/ime/arc_ime_service.cc:241 #2 0x00005ea120666b30 in wm::FocusController::SetFocusedWindow(aura::Window*) () at ../../ui/wm/core/focus_controller.cc:259 #3 0x00005ea12066679e in wm::FocusController::FocusAndActivateWindow(wm::ActivationChangeObserver::ActivationReason, aura::Window*) () at ../../ui/wm/core/focus_controller.cc:228 #4 0x00005ea11ee34a57 in ash::Shell::~Shell() () at ../../ash/shell.cc:720 #5 0x00005ea11ee3690e in ash::Shell::~Shell() () at ../../ash/shell.cc:705 #6 0x00005ea11f20c28d in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() () at ../../../../../../../../../usr/local/google/home/xiyuan/src/cros/.cache/chrome-sdk/tarballs/samus+11079.0.0+target_toolchain/usr/bin/../include/c++/v1/memory:2321 #7 0x00005ea11c7c6c6a in ChromeBrowserMainParts::PostMainMessageLoopRun() () at ../../chrome/browser/chrome_browser_main.cc:1934 #8 0x00005ea11b91db1f in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() () at ../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1130 #9 0x00005ea11aec363e in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() () at ../../content/browser/browser_main_loop.cc:1026 ...
,
Nov 9
I reverted the patch.
,
Nov 15
Scott, the offending CL had been merged to M71 ( crbug.com/891825#c34 ). Did you revert it there too?
,
Nov 15
I did not revert the patch in M71. I didn't realize the patch was merged. Will see about doing a revert there too. I haven't reverted on a branch before, so I don't know if the process is any different.
,
Nov 15
Revert for branch is here: https://chromium-review.googlesource.com/c/chromium/src/+/1338169
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d576e9a44fe4c5b6a07e568f1ebc753f1214634 commit 5d576e9a44fe4c5b6a07e568f1ebc753f1214634 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Tue Nov 20 01:35:25 2018 Reland: Fix text input on ARC++ Kiosk apps. The original CL is crrev.com/c/1291289. It was reverted due to crash. Please see crbug.com/903671 . We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 , 903671 Test: Can type text on Wikipedia kiosk app. Change-Id: I3e6457ee3dc5f3fdcca35a7acbb007325697ddbd Reviewed-on: https://chromium-review.googlesource.com/c/1339779 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#609551} [modify] https://crrev.com/5d576e9a44fe4c5b6a07e568f1ebc753f1214634/components/arc/ime/arc_ime_service.cc
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f3cc28b53360f25187d30e9908d92d7d8abdd5c Commit: 9f3cc28b53360f25187d30e9908d92d7d8abdd5c Author: yhanada@chromium.org Commiter: yhanada@chromium.org Date: 2018-11-27 23:58:28 +0000 UTC Reland: Fix text input on ARC++ Kiosk apps. The original CL is crrev.com/c/1291289. It was reverted due to crash. Please see crbug.com/903671 . We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 , 903671 Test: Can type text on Wikipedia kiosk app. Change-Id: I3e6457ee3dc5f3fdcca35a7acbb007325697ddbd Reviewed-on: https://chromium-review.googlesource.com/c/1339779 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#609551}(cherry picked from commit 5d576e9a44fe4c5b6a07e568f1ebc753f1214634) Reviewed-on: https://chromium-review.googlesource.com/c/1352079 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#834} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f3cc28b53360f25187d30e9908d92d7d8abdd5c commit 9f3cc28b53360f25187d30e9908d92d7d8abdd5c Author: Yuichiro Hanada <yhanada@chromium.org> Date: Tue Nov 27 23:58:28 2018 Reland: Fix text input on ARC++ Kiosk apps. The original CL is crrev.com/c/1291289. It was reverted due to crash. Please see crbug.com/903671 . We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 , 903671 Test: Can type text on Wikipedia kiosk app. Change-Id: I3e6457ee3dc5f3fdcca35a7acbb007325697ddbd Reviewed-on: https://chromium-review.googlesource.com/c/1339779 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#609551}(cherry picked from commit 5d576e9a44fe4c5b6a07e568f1ebc753f1214634) Reviewed-on: https://chromium-review.googlesource.com/c/1352079 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#834} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/9f3cc28b53360f25187d30e9908d92d7d8abdd5c/components/arc/ime/arc_ime_service.cc
,
Dec 14
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by khorimoto@chromium.org
, Nov 9Labels: -Pri-3 Pri-1
Status: Available (was: Untriaged)
Summary: ArcWindowDelegateImpl::IsInArcAppWindow crashes at login (was: ArcWindowDelegateImpl::IsInArcAppWindow crashes sometimes.)