New issue
Advanced search Search tips

Issue 903656 link

Starred by 1 user
Status: Fixed
Owner:
sande...@chromium.org
Closed: Dec 17
Cc:
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Consider reducing LOG(WARNING/ERROR) messages in vt_video_decode/encode_accelerator_mac

Project Member Reported by mcasas@chromium.org, Nov 9 
Every time I see a failing log on a Mac bot [1] is preceded by the vt failing
to initialize the VTDecompressionSession/VTCompressionSession, which is legit
since these are virtual machines. Could we reduce this logging a bit?

e.g.

[3232:775:1108/190554.043283:WARNING:vt_video_decode_accelerator_mac.cc(193)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "codecOpenErr" (-8973)
[3232:775:1108/190554.043743:WARNING:vt_video_decode_accelerator_mac.cc(215)] Hardware decoding with VideoToolbox is not supported
[...]
[3232:775:1108/190554.164286:ERROR:vt_video_encode_accelerator_mac.cc(513)]  VTCompressionSessionCreate failed: -12908


[1] 
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930372744268466992/+/steps/browser_tests_on__none__GPU_on_Mac__without_patch_/0/logs/HasBeforeUnloadHandlerTest.EmptyBeforeUnloadDetected/0
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2810c4cdabdde1085bf671b249d952b1699dc155

commit 2810c4cdabdde1085bf671b249d952b1699dc155
Author: Dan Sanders <sandersd@chromium.org>
Date: Wed Nov 14 19:29:15 2018

[media] Lower log level for VTVDA initialization failure.

It is expected that initialization will fail when it is not supported by
the hardware, so lower these from DLOG(WARN) to DVLOG(1).

Failure to create a software decode session is still DLOG(WARN) because
this should work on all hardware.

Bug:  903656 
Change-Id: I7bd62051c4c1d9082731b393d44166971f1aa0f6
Reviewed-on: https://chromium-review.googlesource.com/c/1334849
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608078}
[modify] https://crrev.com/2810c4cdabdde1085bf671b249d952b1699dc155/media/gpu/vt_video_decode_accelerator_mac.cc

Comment 2 by sande...@chromium.org, Dec 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment