FilesApp share_and_manage_dialog.js [1] lacks sharing tests for Team Drives. Add tests of a file and/or directory for Teams Drives. https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js?type=cs&q=share_and_manage&sq=package:chromium&g=0&l=1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/114c392daa3f0f754a75b80980e1b222ff614dc3 commit 114c392daa3f0f754a75b80980e1b222ff614dc3 Author: Noel Gordon <noel@chromium.org> Date: Fri Nov 09 03:46:28 2018 Add a bug for share_and_manage_dialog.js testing TODO. The TODO has no associateed bug: created one & point the TODO at it. No change in behavior, comment only change. Bug: 903637 , 903587 Change-Id: I087759922064ec3ce6278757542b14c3dc4c5df3 Reviewed-on: https://chromium-review.googlesource.com/c/1327942 Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606728} [modify] https://crrev.com/114c392daa3f0f754a75b80980e1b222ff614dc3/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fcafe0edcfa93257435a18072b5fa6d01858489 commit 8fcafe0edcfa93257435a18072b5fa6d01858489 Author: Sam McNally <sammc@chromium.org> Date: Mon Nov 19 06:52:15 2018 Add tests for sharing and managing items in team drives. Bug: 903637 Change-Id: Ic9f49f7de59210e400a578060eb611fafebe193f Reviewed-on: https://chromium-review.googlesource.com/c/1341287 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609191} [modify] https://crrev.com/8fcafe0edcfa93257435a18072b5fa6d01858489/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/8fcafe0edcfa93257435a18072b5fa6d01858489/ui/file_manager/file_manager/background/js/test_util.js [modify] https://crrev.com/8fcafe0edcfa93257435a18072b5fa6d01858489/ui/file_manager/integration_tests/file_manager/background.js [modify] https://crrev.com/8fcafe0edcfa93257435a18072b5fa6d01858489/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js [modify] https://crrev.com/8fcafe0edcfa93257435a18072b5fa6d01858489/ui/file_manager/integration_tests/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d81109580de4b9dd11b0026f7aa518b4870a460b commit d81109580de4b9dd11b0026f7aa518b4870a460b Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Mon Nov 19 10:42:49 2018 Revert "Add tests for sharing and managing items in team drives." This reverts commit 8fcafe0edcfa93257435a18072b5fa6d01858489. Reason for revert: the CL caused test failure https://bugs.chromium.org/p/chromium/issues/detail?id=906577 Original change's description: > Add tests for sharing and managing items in team drives. > > Bug: 903637 > Change-Id: Ic9f49f7de59210e400a578060eb611fafebe193f > Reviewed-on: https://chromium-review.googlesource.com/c/1341287 > Commit-Queue: Sam McNally <sammc@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609191} TBR=noel@chromium.org,sammc@chromium.org Change-Id: I6385ca389f4f2e8807ee6a34c4a0a27744c5ac39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903637 Reviewed-on: https://chromium-review.googlesource.com/c/1341516 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#609232} [modify] https://crrev.com/d81109580de4b9dd11b0026f7aa518b4870a460b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/d81109580de4b9dd11b0026f7aa518b4870a460b/ui/file_manager/file_manager/background/js/test_util.js [modify] https://crrev.com/d81109580de4b9dd11b0026f7aa518b4870a460b/ui/file_manager/integration_tests/file_manager/background.js [modify] https://crrev.com/d81109580de4b9dd11b0026f7aa518b4870a460b/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js [modify] https://crrev.com/d81109580de4b9dd11b0026f7aa518b4870a460b/ui/file_manager/integration_tests/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56de02ff65a1cd92adae922819e6c58ebbf42472 commit 56de02ff65a1cd92adae922819e6c58ebbf42472 Author: Sam McNally <sammc@chromium.org> Date: Tue Nov 20 01:34:22 2018 Reland "Add tests for sharing and managing items in team drives." This is a reland of 8fcafe0edcfa93257435a18072b5fa6d01858489 Wait for the file list to update before attempting to select its contents. Original change's description: > Add tests for sharing and managing items in team drives. > > Bug: 903637 > Change-Id: Ic9f49f7de59210e400a578060eb611fafebe193f > Reviewed-on: https://chromium-review.googlesource.com/c/1341287 > Commit-Queue: Sam McNally <sammc@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609191} Bug: 903637 , 906577 Change-Id: Id6e2a1ab4eb4b0afb48c53c5cb6ea0e3b28bfa11 Reviewed-on: https://chromium-review.googlesource.com/c/1343399 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609549} [modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/ui/file_manager/file_manager/background/js/test_util.js [modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/ui/file_manager/integration_tests/file_manager/background.js [modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js [modify] https://crrev.com/56de02ff65a1cd92adae922819e6c58ebbf42472/ui/file_manager/integration_tests/test_util.js
Comment 1 by bugdroid1@chromium.org
, Nov 9