New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 903622 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Tethering network doesn't show that it's connecting when the cr-network-list-item is clicked

Project Member Reported by jordynass@google.com, Nov 9

Issue description

Clicking the item causes the network to change but it only listens for changes to the network list, not to changes of individual networks.
 
Cc: steve...@chromium.org jhawkins@chromium.org hansberry@chromium.org jessejames@google.com
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c013bec505027d051c6a8ccc1beca17d25eac028

commit c013bec505027d051c6a8ccc1beca17d25eac028
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Sat Nov 10 03:01:24 2018

[CrOS Tether] Make internet subpage show status on network click

I manually confirmed that it now shows the network state 'Connecting'
and starts connecting when the cr-network-list-item corresponding to a
tethering host is clicked.

Bug:  903622 
Change-Id: Ib7efe3001cd4283065f85327f8a6f56916d825f1
Reviewed-on: https://chromium-review.googlesource.com/c/1328144
Reviewed-by: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607092}
[modify] https://crrev.com/c013bec505027d051c6a8ccc1beca17d25eac028/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/c013bec505027d051c6a8ccc1beca17d25eac028/chrome/browser/resources/settings/internet_page/internet_subpage.js

Status: Fixed (was: Assigned)

Sign in to add a comment