New issue
Advanced search Search tips

Issue 903592 link

Starred by 1 user
Status: Fixed
Owner:
dgarr...@chromium.org
Closed: Jan 11
Cc:
ahass...@chromium.org
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use self._run.options.debug instead of self._run.debug.

Project Member Reported by dgarr...@chromium.org, Nov 9 
Any board specific stage will have the debug flag forced to False during the copy of the BuilderRun instance. This is a long standing bug.

The easiest fix is to update all stages that use self._run.debug to use self._run.options.debug.

Or.... sort through the guts of BuilderRun until the real issue can be sorted out.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/74e4b96e5a22c65a64e054ac188372aacbe75de7

commit 74e4b96e5a22c65a64e054ac188372aacbe75de7
Author: Amin Hassani <ahassani@chromium.org>
Date: Tue Dec 18 04:47:08 2018

release_stages: Pass the correct debug flag.

Pass self._run.options.debug instead of self._run.debug

BUG= chromium:903592 
TEST=payloads-tryjob

Change-Id: Ie21b52a9ffe2edf4d2bcc72d885c5574df8c5161
Reviewed-on: https://chromium-review.googlesource.com/1377909
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/74e4b96e5a22c65a64e054ac188372aacbe75de7/cbuildbot/stages/release_stages.py

Comment 2 by dgarr...@chromium.org, Jan 10

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2a1ee8cd0aeb1d8e3be221d079a6bf37aafd12ca

commit 2a1ee8cd0aeb1d8e3be221d079a6bf37aafd12ca
Author: Don Garrett <dgarrett@google.com>
Date: Fri Jan 11 21:32:18 2019

cbuildbot_run: Remove _BuilderRunBase.debug.

BuilderRun.debug attributes have had a bug for a long time. Instead of
fixing it, just switch to the more reliably value options.debug in all
clients.

BUG= chromium:903592 
TEST=./run_tests

Change-Id: Ib4fedffbd9ef79cba1b36c87950487badcacc81d
Reviewed-on: https://chromium-review.googlesource.com/1405894
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/2a1ee8cd0aeb1d8e3be221d079a6bf37aafd12ca/cbuildbot/cbuildbot_run.py
[modify] https://crrev.com/2a1ee8cd0aeb1d8e3be221d079a6bf37aafd12ca/cbuildbot/stages/vm_test_stages.py
[modify] https://crrev.com/2a1ee8cd0aeb1d8e3be221d079a6bf37aafd12ca/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/2a1ee8cd0aeb1d8e3be221d079a6bf37aafd12ca/cbuildbot/stages/artifact_stages.py
[modify] https://crrev.com/2a1ee8cd0aeb1d8e3be221d079a6bf37aafd12ca/cbuildbot/stages/report_stages.py

Comment 4 by dgarr...@chromium.org, Jan 11

Status: Fixed (was: Started)
►

Sign in to add a comment