New issue
Advanced search Search tips

Issue 903587 link

Starred by 1 user
Status: Fixed
Owner:
noel@chromium.org
Closed: Nov 9
Cc:
lucmult@chromium.org
slangley@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Deflake and cleanup share_and_manage_dialog.js

Project Member Reported by noel@chromium.org, Nov 9 
There is some residual flake in these tests. The URL to be navigated to is null sometimes causing a flake [1] in the 'share' test cases.

Run the ruler over these tests, remove redundant variables, document test steps, find out what is not being waited for correctly and deflake.

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ShareAndManageDialog%2FFilesApp
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62b37c19ba11b77a48b897144b47d43300a74471

commit 62b37c19ba11b77a48b897144b47d43300a74471
Author: Noel Gordon <noel@chromium.org>
Date: Fri Nov 09 02:25:32 2018

Cleanup share_and_manage_dialog.js integration test

- document the test helpers and their test steps.
- change share() and manage(): use more specific names.
- in the share test: wait for the file/directory entry to
  be selected before proceeding to the next step.
- in the share test: wait for share menu to close before
  trying to get the browser URL to avoid flakes.

Bug:  903587 
Change-Id: I666b6c828e348a41b6053b54b6094d04fb3b9def
Reviewed-on: https://chromium-review.googlesource.com/c/1328082
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606704}
[modify] https://crrev.com/62b37c19ba11b77a48b897144b47d43300a74471/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js

Comment 2 by noel@chromium.org, Nov 9

Cc: slangley@chromium.org
TODO in this code had no bug. Filed  issue 903637  to address the TODO.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/114c392daa3f0f754a75b80980e1b222ff614dc3

commit 114c392daa3f0f754a75b80980e1b222ff614dc3
Author: Noel Gordon <noel@chromium.org>
Date: Fri Nov 09 03:46:28 2018

Add a bug for share_and_manage_dialog.js testing TODO.

The TODO has no associateed bug: created one & point the TODO at it. No
change in behavior, comment only change.

Bug:  903637 ,  903587 
Change-Id: I087759922064ec3ce6278757542b14c3dc4c5df3
Reviewed-on: https://chromium-review.googlesource.com/c/1327942
Reviewed-by: Anand Mistry <amistry@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606728}
[modify] https://crrev.com/114c392daa3f0f754a75b80980e1b222ff614dc3/ui/file_manager/integration_tests/file_manager/share_and_manage_dialog.js

Comment 4 by noel@chromium.org, Nov 9

Status: Fixed (was: Untriaged)
►

Sign in to add a comment